Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT with DCHECK_op, NOTREACHED, CHECK_op respectively.
I will start working on this.
Thanks mrunal!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f87b160ef34de0585a820a598cb75ce6ecdd1da9 commit f87b160ef34de0585a820a598cb75ce6ecdd1da9 Author: mrunal.kapade <mrunal.kapade@intel.com> Date: Tue Mar 21 01:10:53 2017 Replace RELEASE_ASSERT with CHECK in core/layout/ BUG= 697685 Review-Url: https://codereview.chromium.org/2754723004 Cr-Commit-Position: refs/heads/master@{#458266} [modify] https://crrev.com/f87b160ef34de0585a820a598cb75ce6ecdd1da9/third_party/WebKit/Source/core/layout/LayoutBlock.cpp [modify] https://crrev.com/f87b160ef34de0585a820a598cb75ce6ecdd1da9/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp [modify] https://crrev.com/f87b160ef34de0585a820a598cb75ce6ecdd1da9/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/f87b160ef34de0585a820a598cb75ce6ecdd1da9/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/f87b160ef34de0585a820a598cb75ce6ecdd1da9/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp [modify] https://crrev.com/f87b160ef34de0585a820a598cb75ce6ecdd1da9/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp [modify] https://crrev.com/f87b160ef34de0585a820a598cb75ce6ecdd1da9/third_party/WebKit/Source/core/layout/TextAutosizer.cpp [modify] https://crrev.com/f87b160ef34de0585a820a598cb75ce6ecdd1da9/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp [modify] https://crrev.com/f87b160ef34de0585a820a598cb75ce6ecdd1da9/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc [modify] https://crrev.com/f87b160ef34de0585a820a598cb75ce6ecdd1da9/third_party/WebKit/Source/core/layout/ng/ng_inline_node.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83 commit 1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83 Author: mrunal.kapade <mrunal.kapade@intel.com> Date: Fri Mar 24 05:35:18 2017 Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/ BUG= 697685 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2758683002 Cr-Commit-Position: refs/heads/master@{#459364} [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/CounterNode.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutBlock.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutGrid.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutInline.h [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutMedia.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutQuote.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutRuby.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutRuby.h [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutTable.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutTableCol.h [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/LayoutTheme.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/ListMarkerText.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/line/InlineBox.h [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/line/LineBreaker.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.cc [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/shapes/Shape.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/SVGResources.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/SVGResourcesCycleSolver.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp [modify] https://crrev.com/1fc2d4de3e297b0ec74a5a34333cf7fcf7c39c83/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39 commit 7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39 Author: mrunal.kapade <mrunal.kapade@intel.com> Date: Tue Mar 28 02:16:19 2017 Replace ASSERT with DCHECK in core/layout/<sub dirs> Next patch should cover files in core/layout/ itself. BUG= 697685 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2748103015 Cr-Commit-Position: refs/heads/master@{#459988} [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/api/LineLayoutSVGInlineText.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/InlineBox.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/InlineBox.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/InlineIterator.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/InlineTextBox.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/LineBoxList.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/LineBreaker.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/LineWidth.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/RootInlineBox.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/TrailingObjects.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/line/TrailingObjects.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/shapes/BoxShape.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/shapes/PolygonShape.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/shapes/RasterShape.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/shapes/RectangleShape.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/shapes/Shape.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGEllipse.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGGradientStop.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGPath.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/SVGResources.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/SVGResourcesCycleSolver.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineSpacing.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp [modify] https://crrev.com/7cd03f7e88b6e5d1f98d44c1fa01cf63eb889b39/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2fa2002398888f73a3f1848a34340b37168b31a commit e2fa2002398888f73a3f1848a34340b37168b31a Author: mrunal.kapade <mrunal.kapade@intel.com> Date: Wed Apr 05 02:40:06 2017 Replace ASSERT with DCHECK in core/layout/ excluding subdirs BUG= 697685 Review-Url: https://codereview.chromium.org/2770123003 Cr-Commit-Position: refs/heads/master@{#461948} [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/CounterNode.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/FloatingObjects.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/FloatingObjects.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/HitTestRequest.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/HitTestResult.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/ImageQualityController.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutBlock.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutBox.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutButton.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutCounter.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutFileUploadControl.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutFrameSet.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutIFrame.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutImage.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutImageResource.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutInline.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutInline.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutListBox.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutMedia.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutMedia.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutObjectInlines.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutPagedFlowThread.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutPart.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutQuote.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutRuby.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutSearchField.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutSlider.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTable.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTable.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTableCell.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTableRow.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutText.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTextCombine.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTextControlMultiLine.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTheme.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutView.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/LayoutView.h [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/ListMarkerText.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/PaintContainmentTest.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/TextAutosizer.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/TextRunConstructor.cpp [modify] https://crrev.com/e2fa2002398888f73a3f1848a34340b37168b31a/third_party/WebKit/Source/core/layout/ViewFragmentationContext.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fe329196d1596b0e516fda0727e8ebce5996152 commit 2fe329196d1596b0e516fda0727e8ebce5996152 Author: mrunal.kapade <mrunal.kapade@intel.com> Date: Thu Apr 06 21:17:48 2017 Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary This one is for the existing DCHECKS which were already present. BUG= 697685 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2770203002 Cr-Commit-Position: refs/heads/master@{#462623} [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/Grid.cpp [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/LayoutState.cpp [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.h [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/ng/ng_inline_node.h [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h [modify] https://crrev.com/2fe329196d1596b0e516fda0727e8ebce5996152/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/942077b08a652ac7fdb0f51f02c1a6fd44fd4cc8 commit 942077b08a652ac7fdb0f51f02c1a6fd44fd4cc8 Author: mrunal.kapade <mrunal.kapade@intel.com> Date: Thu Apr 13 22:44:41 2017 Replace remaining ASSERTs and ASSERT_NOT_REACHED in core/layout/ It looks like these were added recently in last 2-3 weeks. BUG= 697685 Review-Url: https://codereview.chromium.org/2800243002 Cr-Commit-Position: refs/heads/master@{#464582} [modify] https://crrev.com/942077b08a652ac7fdb0f51f02c1a6fd44fd4cc8/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc [modify] https://crrev.com/942077b08a652ac7fdb0f51f02c1a6fd44fd4cc8/third_party/WebKit/Source/core/layout/ng/ng_space_utils.cc
Comment 1 by tkent@chromium.org
, Mar 2 2017