New issue
Advanced search Search tips

Issue 697675 link

Starred by 2 users
Status: WontFix
Owner:
ccameron@chromium.org
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 667431



Sign in to add a comment

Color correct rasterization using skia kNonLinearBlending_ColorSpaceFlag

Project Member Reported by ccameron@chromium.org, Mar 2 2017 
Rasterize content into a coherent color space.
- use the kNonLinearBlending_ColorSpaceFlag flag for output resource spaces
- tag images in Blink as being in their appropriate color space

This bug is to replace  issue 667411 , which is not going to be pursued.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1d1869a2f3bd20a7eb37461df98eae8f7213de6

commit f1d1869a2f3bd20a7eb37461df98eae8f7213de6
Author: ccameron <ccameron@chromium.org>
Date: Fri Mar 03 03:22:45 2017

cc: Specify rasterization color space

Specify to use nonlinear blended color spaces for rasterization.

Add gfx::ColorSpace accessor to create this SkColorSpace.

BUG= 697675 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2727063002
Cr-Commit-Position: refs/heads/master@{#454499}

[modify] https://crrev.com/f1d1869a2f3bd20a7eb37461df98eae8f7213de6/cc/resources/resource_provider.cc
[modify] https://crrev.com/f1d1869a2f3bd20a7eb37461df98eae8f7213de6/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/f1d1869a2f3bd20a7eb37461df98eae8f7213de6/ui/gfx/color_space.cc
[modify] https://crrev.com/f1d1869a2f3bd20a7eb37461df98eae8f7213de6/ui/gfx/color_space.h
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24c87c3f418983673089663bb69045451d54f52d

commit 24c87c3f418983673089663bb69045451d54f52d
Author: ccameron <ccameron@chromium.org>
Date: Tue Mar 14 21:50:42 2017

color: Always use parametric color spaces for raster

Rasterization must always be done to a parametric color space.

Display may be done to any color space.

Make ICCProfile::GetParametricColorSpace always return a parametric
color space (approximated if need be), and pass this to functions
specifying the space for rasterization.

Make ICCProfile::GetColorSpace return a space that references the
ICCProfile directly, and use the profile for color transforms
if the parametric version is not accurate.

Pass the ICCProfile to ui::Compositor, so that it can send
GetColorSpace to the GLRenderer and GetParametricColorSpace
to the LayerTreeHost.

R=hubbe
TBR=esprehn
BUG= 697675 

Review-Url: https://codereview.chromium.org/2742613002
Cr-Commit-Position: refs/heads/master@{#456849}

[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/content/renderer/render_widget.cc
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/aura/window_tree_host.cc
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/compositor/compositor.cc
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/compositor/compositor.h
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/gfx/color_space.cc
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/gfx/color_space.h
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/gfx/color_space_win.cc
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/gfx/color_transform.cc
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/gfx/icc_profile.cc
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/gfx/icc_profile.h
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/gfx/icc_profile_unittest.cc
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/gfx/skia_color_space_util.cc
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/gfx/skia_color_space_util.h
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/gfx/test/icc_profiles.cc
[modify] https://crrev.com/24c87c3f418983673089663bb69045451d54f52d/ui/gfx/test/icc_profiles.h

Comment 3 by ccameron@chromium.org, Mar 15 2017

Status: WontFix (was: Assigned)
We are going with  issue 701942  instead.
►

Sign in to add a comment