New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697668 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 697669
issue 703762

Blocking:
issue 664704



Sign in to add a comment

Network grouping has unpredictable stacking of timing bars in waterfall

Project Member Reported by allada@chromium.org, Mar 2 2017

Issue description

Right now if you turn grouping experiment on in network panel there is an unpredictable view of how resources stack on top of each other when group is closed.
 
Blockedon: 697669
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e8277dbaf900a53ab0ec812a030ac4a95f7323a

commit 3e8277dbaf900a53ab0ec812a030ac4a95f7323a
Author: allada <allada@chromium.org>
Date: Thu Mar 09 19:54:02 2017

[Devtools] Moved network waterfall to draw all text as a layer

This patch is a series of patches that moves network waterfall to draw in
layers. This is the patch specifically to move text to be caluclated then
drawn all at once.

R=caseq
BUG= 697668 , 664704 

Review-Url: https://codereview.chromium.org/2726103002
Cr-Commit-Position: refs/heads/master@{#455839}

[modify] https://crrev.com/3e8277dbaf900a53ab0ec812a030ac4a95f7323a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5856f08dd586fcc0700e6bc079d5c7099ae5358c

commit 5856f08dd586fcc0700e6bc079d5c7099ae5358c
Author: allada <allada@chromium.org>
Date: Fri Mar 10 02:13:58 2017

[Devtools] Inline _drawSimplifiedBarDetails in NetworkWaterfallColumn.js

This patch simply inlines _drawSimplifiedBarDetails. This is because
this function's functionality will be reduced in future patches and will
make it eassier to review follup patches.

R=caseq
BUG= 697668 

Review-Url: https://codereview.chromium.org/2730633002
Cr-Commit-Position: refs/heads/master@{#455959}

[modify] https://crrev.com/5856f08dd586fcc0700e6bc079d5c7099ae5358c/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9bca9acea99f9dae1e01260405509edba7271d7

commit b9bca9acea99f9dae1e01260405509edba7271d7
Author: allada <allada@chromium.org>
Date: Fri Mar 10 03:11:02 2017

[Devtools] Finished inlining function for _drawSimplifiedBars

This is a followup to https://codereview.chromium.org/2730633002/ to
finish inlining the function.

R=caseq
BUG= 697668 

Review-Url: https://codereview.chromium.org/2726183004
Cr-Commit-Position: refs/heads/master@{#455976}

[modify] https://crrev.com/b9bca9acea99f9dae1e01260405509edba7271d7/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09a524bf16691a0fd873d1d24edf04c8aae8874d

commit 09a524bf16691a0fd873d1d24edf04c8aae8874d
Author: allada <allada@chromium.org>
Date: Fri Mar 10 04:20:32 2017

[Devtools] Network waterfall to use Path2D to draw in layers

This patch introduces changes network waterfall canvas to use Path2D to
draw it's canvas items. This is in preporation to move it to use full
layers. (Followup patch will move the code to use the same path
for artifacts that are the same style)

R=caseq
BUG= 697668 

Review-Url: https://codereview.chromium.org/2731633002
Cr-Commit-Position: refs/heads/master@{#455992}

[modify] https://crrev.com/09a524bf16691a0fd873d1d24edf04c8aae8874d/third_party/WebKit/LayoutTests/http/tests/inspector/network/waterfall-images-expected.png
[modify] https://crrev.com/09a524bf16691a0fd873d1d24edf04c8aae8874d/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Comment 6 by allada@chromium.org, Mar 21 2017

Blockedon: 703762
Status: Fixed (was: Assigned)

Sign in to add a comment