whitespace-integer.html LayoutTest is badly broken |
||
Issue descriptionChrome Version: 56 What steps will reproduce the problem? (1) Open WebKit/LayoutTests/svg/parser/whitespace-integer.html What is the expected result? Test that either passes or fails in a sane way. What happens instead? Test fails in an insane way, and takes about 10s to complete. I have a patch that makes it saner, and run in fraction of a second.
,
Mar 3 2017
https://codereview.chromium.org/2721243004 This is what I have so far. Got derailed trying to generate new test expectations.
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3d4d93c503aa6b59908bb7bda912bd22a7fd1fa commit d3d4d93c503aa6b59908bb7bda912bd22a7fd1fa Author: atotic <atotic@chromium.org> Date: Fri Mar 10 19:15:55 2017 Fix obviously broken SVG parsing test While running LayoutTests, this test timed out. I was curious, looked into it, and realized that the test was completely broken: 1) there was an extra argument getting passed to testType() resulting in assert function being garbage. This caused 1000s of failures which caused test to run slowly. 2) Some other arguments being passed in were also wrong. My fix is not perfect, but it results in a saner outcome: it runs in fraction of a second, and triggers fewer failures. Running LayoutTests on my local machine was impossible, so I have not generated new test expectations. BUG= 697646 Review-Url: https://codereview.chromium.org/2721243004 Cr-Commit-Position: refs/heads/master@{#456127} [modify] https://crrev.com/d3d4d93c503aa6b59908bb7bda912bd22a7fd1fa/third_party/WebKit/LayoutTests/svg/parser/whitespace-integer-expected.txt [modify] https://crrev.com/d3d4d93c503aa6b59908bb7bda912bd22a7fd1fa/third_party/WebKit/LayoutTests/svg/parser/whitespace-integer.html
,
Apr 11 2017
This is fixed now, yes?
,
Apr 11 2017
Yes, fixed indeed. Thanks for the ping. |
||
►
Sign in to add a comment |
||
Comment 1 by schenney@chromium.org
, Mar 3 2017Labels: Test-Layout PaintTeamTriaged-20170302 BugSource-Chromium OS-Linux OS-Mac OS-Windows
Owner: schenney@chromium.org
Status: Assigned (was: Available)