Issue metadata
Sign in to add a comment
|
git cl: If -m is given, don't prompt for patchset title. |
||||||||||||||||||||||
Issue descriptionThis would match the behavior of git cl upload for Rietveld. I think the change would be around here: https://cs.chromium.org/chromium/tools/depot_tools/git_cl.py?l=2680 Another related thought: If --force is given, it would also make sense to accept default patchset title and not prompt.
,
Mar 2 2017
,
Mar 2 2017
> If --force is given, it would also make sense to accept default patchset title and not prompt. I'll check that too.
,
Mar 8 2017
Blocked on issue 689652 , because that issue has 2 pending CLs that refactor tests, on which work in this bug will be based.
,
Apr 10 2017
--force indeed still asked for a title. Fix: https://chromium-review.googlesource.com/472749
,
Apr 10 2017
Oh, wow, I didn't realize that "-m|--message" is actually used as a comment in Rietveld if it is not the first upload (and also as a patchset).
,
Apr 10 2017
This CL will actually fix the bug: https://chromium-review.googlesource.com/472724
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e00a29ba9e6998946e7cd6409bbc2c1a9d01277c commit e00a29ba9e6998946e7cd6409bbc2c1a9d01277c Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon Apr 10 13:00:31 2017 Gerrit git cl upload -f should not ask for title. R=sergiyb@chromium.org BUG= 697625 Change-Id: I2c3ad4e9380bd667c149be09eabeb5af0a5ab020 Reviewed-on: https://chromium-review.googlesource.com/472749 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/e00a29ba9e6998946e7cd6409bbc2c1a9d01277c/git_cl.py
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2d8a2074c5dea835390bb6679b89cd0e0832a1e0 commit 2d8a2074c5dea835390bb6679b89cd0e0832a1e0 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon Apr 10 13:06:02 2017 Gerrit git cl upload: if -m is given, don't prompt for patchset title. R=sergiyb@chromium.org BUG= 697625 Change-Id: I493bcc9212baf9030270cb71cf75ac969a67f2a0 Reviewed-on: https://chromium-review.googlesource.com/472724 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> [modify] https://crrev.com/2d8a2074c5dea835390bb6679b89cd0e0832a1e0/git_cl.py
,
Apr 10 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by qyears...@chromium.org
, Mar 1 2017Labels: -OS-Linux
Status: Available (was: Unconfirmed)