New issue
Advanced search Search tips

Issue 697624 link

Starred by 1 user
Status: Assigned
Owner:
stkhapugin@chromium.org
Cc:
jdonnelly@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ZeroSuggest: The Current URL Suggestion Should Show Its Title

Project Member Reported by mpear...@chromium.org, Mar 1 2017 

On a browser configured to see contextual zero suggestions,
1. Go to a page that offers suggestions such as http://www.garydanko.com/
2. Focus in the omnibox.  Notice the suggestions.
3. Observe that the top item in the dropdown is the current URL.

Expected results:
1. The top item should include the title of the current page.

Observed results:
1. The top item is just the current URL, no title.

Comment 1 by mpear...@chromium.org, Mar 1 2017

Owner: gcomanici@chromium.org
Status: Assigned (was: Available)
Summary: ZeroSuggest: The Current URL Suggestion Should Show Its Title (was: ZeroSuggest: The Current URL Show Include Its Title)
gcomanici@, do you mind if I hand this off to you?

Comment 2 by gcomanici@chromium.org, Mar 8 2017 

I prepared https://codereview.chromium.org/2738003002/ to fix this. See attachment for a snapshot of the fix.
WieSqBXgcE8.png
358 KB View Download

Comment 3 by mpear...@chromium.org, Mar 9 2017 

Screenshot looks good. :-)  I'm not confdient about the particular implementation, as I commented on the changelist.

Comment 4 by mpear...@chromium.org, Apr 11 2017

Labels: OS-All
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cabc77f6204866cbcdc8d581e130f287acaeb06

commit 8cabc77f6204866cbcdc8d581e130f287acaeb06
Author: gcomanici <gcomanici@chromium.org>
Date: Thu Apr 27 20:04:54 2017

Add title to current page in zero suggest.

TBR=jochen
for mechanical changes to chrome/browser/extensions/api/omnibox/* and chrome/browser/android/omnibox/*

BUG=697624

Review-Url: https://codereview.chromium.org/2738003002
Cr-Commit-Position: refs/heads/master@{#467762}

[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/about_flags.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/android/omnibox/autocomplete_controller_android.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/autocomplete/autocomplete_browsertest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/ui/app_list/search/omnibox_provider.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/ui/webui/options/home_page_overlay_handler.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/chrome/browser/ui/webui/options/startup_pages_handler.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/autocomplete_classifier.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/autocomplete_input.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/autocomplete_input.h
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/autocomplete_input_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/autocomplete_match_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/autocomplete_provider_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/autocomplete_result_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/bookmark_provider_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/builtin_provider_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/clipboard_url_provider.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/clipboard_url_provider_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/history_quick_provider_performance_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/history_quick_provider_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/history_url_provider_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/keyword_provider_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/omnibox_field_trial.h
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/physical_web_provider.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/physical_web_provider_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/shortcuts_provider_test_util.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/shortcuts_provider_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/titled_url_match_utils_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/verbatim_match.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/verbatim_match.h
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/zero_suggest_provider.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/zero_suggest_provider.h
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/components/omnibox/browser/zero_suggest_provider_unittest.cc
[modify] https://crrev.com/8cabc77f6204866cbcdc8d581e130f287acaeb06/tools/metrics/histograms/histograms.xml

Comment 6 by gcomanici@chromium.org, Apr 27 2017 

Revision  https://chromium.googlesource.com/chromium/src.git/+/8cabc77f6204866cbcdc8d581e130f287acaeb06 provides the functionality on Desktop. This bug will be open until the functionality is provided on Android as well.

Comment 7 by mpear...@chromium.org, Apr 27 2017

Labels: -OS-All OS-Android

Comment 8 by mpear...@chromium.org, Jun 26 2017

Components: -UI>Browser>Omnibox UI>Browser>Omnibox>ZeroSuggest
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0837521974e3f3db90f9706978b9631b755b02a

commit a0837521974e3f3db90f9706978b9631b755b02a
Author: Gheorghe Comanici <gcomanici@chromium.org>
Date: Fri Dec 01 20:20:00 2017

[omnibox] Android - add title to current page in zero suggest.

Bug: 697624, 787940
Change-Id: I13768958722eef31361336b504efe9e93b84c054
Reviewed-on: https://chromium-review.googlesource.com/798192
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521033}
[modify] https://crrev.com/a0837521974e3f3db90f9706978b9631b755b02a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java
[modify] https://crrev.com/a0837521974e3f3db90f9706978b9631b755b02a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/a0837521974e3f3db90f9706978b9631b755b02a/chrome/browser/about_flags.cc
[modify] https://crrev.com/a0837521974e3f3db90f9706978b9631b755b02a/chrome/browser/android/omnibox/autocomplete_controller_android.cc
[modify] https://crrev.com/a0837521974e3f3db90f9706978b9631b755b02a/chrome/browser/android/omnibox/autocomplete_controller_android.h
[modify] https://crrev.com/a0837521974e3f3db90f9706978b9631b755b02a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/OmniboxTestUtils.java

Comment 10 by gcomanici@chromium.org, Dec 4 2017

Labels: -OS-Android OS-iOS

Comment 11 by mpear...@chromium.org, Dec 5 2017

Labels: Merge-Request-64
Requesting a merge.  This is a bug fix for a feature that's enabled for dogfooders and 10% of the dev channel.  It would be best if these users can see the feature as it was intended.  The change is already in canary without any signs of a problem.  The patch is low risk.
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 6 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 6 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1fc6cd78ca2bbe99b77f1fcb3750b833fb6380b

commit b1fc6cd78ca2bbe99b77f1fcb3750b833fb6380b
Author: Gheorghe Comanici <gcomanici@chromium.org>
Date: Wed Dec 06 19:08:04 2017

[omnibox] Android - add title to current page in zero suggest.

Bug: 697624, 787940
Change-Id: I13768958722eef31361336b504efe9e93b84c054
Reviewed-on: https://chromium-review.googlesource.com/798192
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521033}(cherry picked from commit a0837521974e3f3db90f9706978b9631b755b02a)
Reviewed-on: https://chromium-review.googlesource.com/811466
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#62}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/b1fc6cd78ca2bbe99b77f1fcb3750b833fb6380b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java
[modify] https://crrev.com/b1fc6cd78ca2bbe99b77f1fcb3750b833fb6380b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/b1fc6cd78ca2bbe99b77f1fcb3750b833fb6380b/chrome/browser/about_flags.cc
[modify] https://crrev.com/b1fc6cd78ca2bbe99b77f1fcb3750b833fb6380b/chrome/browser/android/omnibox/autocomplete_controller_android.cc
[modify] https://crrev.com/b1fc6cd78ca2bbe99b77f1fcb3750b833fb6380b/chrome/browser/android/omnibox/autocomplete_controller_android.h
[modify] https://crrev.com/b1fc6cd78ca2bbe99b77f1fcb3750b833fb6380b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/OmniboxTestUtils.java

Comment 14 by mpear...@chromium.org, Dec 6 2017

Status: Fixed (was: Assigned)

Comment 15 by mpear...@chromium.org, Dec 18 2017

Status: Assigned (was: Fixed)
gcomanici@, you marked this bug as fixed.  Is the code in place on iOS?

Comment 16 by gcomanici@google.com, Dec 19 2017 

I didn't mark this fixed. mpearson@ did on Dec 6th :P

I still have to do the iOS part. Let's keep this open.

Comment 17 by gcomanici@chromium.org, Jan 29 2018

Status: Available (was: Assigned)

Comment 18 by gcomanici@chromium.org, Jan 29 2018

Owner: ----

Comment 19 by mpear...@chromium.org, Jan 30 2018

Cc: jdonnelly@chromium.org
NextAction: 2018-03-03
CC jdonnelly as an FYI.

This is being evaluated on Android as part of bug 787940.  This bug is about the missing iOS implementation.  By the end of March, we should've made a decision on Android, which would help prioritize this.

Comment 20 by monor...@bugs.chromium.org, Mar 3 2018 

The NextAction date has arrived: 2018-03-03

Comment 21 by mpear...@chromium.org, May 10 2018

NextAction: ----
Android is launching.  iOS is the only platform remaining.  It should be easy to pipeline the title of the page into the omnibox system.  Hopefully someone can pick it up.

Comment 22 by stkhapugin@chromium.org, Aug 8

Owner: stkhapugin@chromium.org
Status: Assigned (was: Available)
►

Sign in to add a comment