Add a trace event in FrameLoader::updateForSameDocumentNavigation. |
|||
Issue descriptionAdd a trace event in FrameLoader::updateForSameDocumentNavigation. FrameLoader::updateForSameDocumentNavigation is the central point for same document navigations. In order to write metrics for same document navigations, we need to expose this central point in tracing. Same document navigation and SPA (Single Page Application) navigation are inter-changable in this context. Doc: https://docs.google.com/document/d/1B44Aqym4rRNlghlMNzSR2clIZhdvVyhQ2LMmvRKEkW0/edit?usp=sharing
,
Mar 7 2017
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/883d0479494ebd6c5351af89cd575da2e2127030 commit 883d0479494ebd6c5351af89cd575da2e2127030 Author: sunjian <sunjian@chromium.org> Date: Tue Mar 07 21:59:11 2017 Add a trace event in FrameLoader::updateForSameDocumentNavigation. Currently, we are exposing History::pushState and Location::setHash in tracing. These two events are seen as the indicators of a spa navigation. However, we found out that FrameLoader::updateForSameDocumentNavigation is the central point for same document navigation (aka spa navigation). Therefore, we can remove trace events in History::pushState and Location::setHash and add a trace event in the central point instead. BUG= 697617 Review-Url: https://codereview.chromium.org/2724943003 Cr-Commit-Position: refs/heads/master@{#455236} [modify] https://crrev.com/883d0479494ebd6c5351af89cd575da2e2127030/third_party/WebKit/Source/core/frame/History.cpp [modify] https://crrev.com/883d0479494ebd6c5351af89cd575da2e2127030/third_party/WebKit/Source/core/frame/Location.cpp [modify] https://crrev.com/883d0479494ebd6c5351af89cd575da2e2127030/third_party/WebKit/Source/core/loader/FrameLoader.cpp
,
Apr 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sunjian@chromium.org
, Mar 7 2017