New issue
Advanced search Search tips

Issue 697615 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 690704
issue 697603



Sign in to add a comment

Build failure in cert_verify_tool

Project Member Reported by a...@chromium.org, Mar 1 2017

Issue description

Regression with r453731.

[8321/500/12642] LINK ./cert_verify_tool
FAILED: cert_verify_tool 
TOOL_VERSION=1477670870 ../../build/toolchain/mac/linker_driver.py ../../third_party/llvm-build/Release+Asserts/bin/clang++  -stdlib=libc++ -arch x86_64 -Werror -Wl,-dead_strip -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9 -Wl,-ObjC -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -Wl,-pie -o "./cert_verify_tool" -Wl,-filelist,"./cert_verify_tool.rsp" ./libnet.dylib ./libbase.dylib ./libprotobuf_lite.dylib ./libcrcrypto.dylib ./libboringssl.dylib ./liburl.dylib ./libbase_i18n.dylib ./libicui18n.dylib ./libicuuc.dylib ./libnet_with_v8.dylib -framework AppKit
Undefined symbols for architecture x86_64:
  "_kSecPolicyAppleSSL", referenced from:
      VerifyUsingPathBuilder(CertInput const&, std::__1::vector<CertInput, std::__1::allocator<CertInput> > const&, std::__1::vector<CertInput, std::__1::allocator<CertInput> > const&, base::Time, base::FilePath const&) in verify_using_path_builder.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
  File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
    Main(sys.argv)
  File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
    subprocess.check_call(compiler_driver_args)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../third_party/llvm-build/Release+Asserts/bin/clang++', '-stdlib=libc++', '-arch', 'x86_64', '-Werror', '-Wl,-dead_strip', '-isysroot', '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk', '-mmacosx-version-min=10.9', '-Wl,-ObjC', '-Wl,-rpath,@loader_path/.', '-Wl,-rpath,@loader_path/../../..', '-Wl,-pie', '-o', './cert_verify_tool', '-Wl,-filelist,./cert_verify_tool.rsp', './libnet.dylib', './libbase.dylib', './libprotobuf_lite.dylib', './libcrcrypto.dylib', './libboringssl.dylib', './liburl.dylib', './libbase_i18n.dylib', './libicui18n.dylib', './libicuuc.dylib', './libnet_with_v8.dylib', '-framework', 'AppKit']' returned non-zero exit status 1

 
This doesn't appear on any bots. Could you indicate what might be different about your build environment to trigger this?

Comment 2 by a...@chromium.org, Mar 1 2017

This is failing on my local build. Maybe it's that I use the 10.12 SDK?

Comment 3 by mattm@chromium.org, Mar 1 2017

Curious, could be. Looks like my mac is on sdk 10.11, which does work.

The definition of the constant changed from "extern CFTypeRef kSecPolicyAppleSSL" to "extern const CFStringRef kSecPolicyAppleSSL", but that change happened in 10.11 so dunno if it could be related at all.

Comment 4 by a...@chromium.org, Mar 1 2017

Maybe they export that symbol in a different library in the 10.12 sdk and you have to adjust the linking info?
Blocking: 697603
Cc: erikc...@chromium.org
We're seeing this on a bunch of bots in  bug 697603  too. +erikchen because hermetic Xcode (or lack of it).

Comment 6 by mattm@chromium.org, Mar 2 2017

Status: Started (was: Assigned)
Ok, I can repro locally with a clang build.  Fix on the way..
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49957feee8c5ea46bc551e669e370164b6852702

commit 49957feee8c5ea46bc551e669e370164b6852702
Author: mattm <mattm@chromium.org>
Date: Thu Mar 02 01:45:29 2017

Mac cert_verify_tool: add Security.framework library dep.

Fixes clang build.

BUG= 697615 , 697603 

Review-Url: https://codereview.chromium.org/2721313003
Cr-Commit-Position: refs/heads/master@{#454142}

[modify] https://crrev.com/49957feee8c5ea46bc551e669e370164b6852702/net/BUILD.gn

Comment 8 by mattm@chromium.org, Mar 2 2017

Status: Fixed (was: Started)

Sign in to add a comment