New issue
Advanced search Search tips

Issue 697603 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 697615



Sign in to add a comment

ClangToTMac failing to compile

Project Member Reported by h...@chromium.org, Mar 1 2017

Issue description

Last good:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTMac/builds/13299
Clang: 296513

First bad:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTMac/builds/13300
Clang: 296535


[33357/39692] LINK ./cert_verify_tool
FAILED: cert_verify_tool 
export DEVELOPER_DIR=/b/c/b/ClangToTMac/src/build/mac_files/Xcode.app;  TOOL_VERSION=1486593434 ../../build/toolchain/mac/linker_driver.py ../../third_party/llvm-build/Release+Asserts/bin/clang++  -stdlib=libc++ -arch x86_64 -Werror -isysroot /b/c/b/ClangToTMac/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.9 -Wl,-ObjC -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -Wl,-pie -o "./cert_verify_tool" -Wl,-filelist,"./cert_verify_tool.rsp" ./libnet.dylib ./libbase.dylib ./libprotobuf_lite.dylib ./libcrcrypto.dylib ./libboringssl.dylib ./liburl.dylib ./libbase_i18n.dylib ./libicui18n.dylib ./libicuuc.dylib ./libnet_with_v8.dylib -framework AppKit
Undefined symbols for architecture x86_64:
  "_kSecPolicyAppleSSL", referenced from:
      VerifyUsingPathBuilder(CertInput const&, std::__1::vector<CertInput, std::__1::allocator<CertInput> > const&, std::__1::vector<CertInput, std::__1::allocator<CertInput> > const&, base::Time, base::FilePath const&) in verify_using_path_builder.o
ld: symbol(s) not found for architecture x86_64
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
  File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
    Main(sys.argv)
  File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
    subprocess.check_call(compiler_driver_args)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../third_party/llvm-build/Release+Asserts/bin/clang++', '-stdlib=libc++', '-arch', 'x86_64', '-Werror', '-isysroot', '/b/c/b/ClangToTMac/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk', '-mmacosx-version-min=10.9', '-Wl,-ObjC', '-Wl,-rpath,@loader_path/.', '-Wl,-rpath,@loader_path/../../..', '-Wl,-pie', '-o', './cert_verify_tool', '-Wl,-filelist,./cert_verify_tool.rsp', './libnet.dylib', './libbase.dylib', './libprotobuf_lite.dylib', './libcrcrypto.dylib', './libboringssl.dylib', './liburl.dylib', './libbase_i18n.dylib', './libicui18n.dylib', './libicuuc.dylib', './libnet_with_v8.dylib', '-framework', 'AppKit']' returned non-zero exit status 1

 
smeenai earlier told me:

<smeenai> Around?
<thakis> yes
* [smeenai] is away (Auto-away)
<smeenai> Hi
<smeenai> I just wanted to give you a heads up that I'll be submitting https://reviews.llvm.org/D25208 and https://reviews.llvm.org/D29157 soon, to enable building libc++ with hidden visibility
<smeenai> There's some potential for these to re-trigger something like https://bugs.llvm.org//show_bug.cgi?id=30642
<smeenai> I'm pretty sure I've annotated all the problematic cases
<smeenai> But if you see a visibility regression in Chrome again, just let me know and I can take a look pronto

Maybe that's related?

Comment 2 by h...@chromium.org, Mar 1 2017

He pinged me too. Looks like those haven't been committed yet though, and this started yesterday afternoon.

Comment 3 by h...@chromium.org, Mar 1 2017

I can reproduce this locally. Rolling back Clang to r296513 didn't help.

Reverting https://codereview.chromium.org/2585963003 does though

How are non-ToT Mac bots handling this?

Comment 4 by h...@chromium.org, Mar 1 2017

This one seems to handle it fine: https://build.chromium.org/p/chromium/builders/Mac/builds/24251/steps/compile/logs/stdio

Some kind of infra thing?
Cc: mattm@chromium.org
mattm, does https://codereview.chromium.org/2585963003 require some minimum Xcode version? Some minimum SDK version?

Most bots use the hermetic Xcode these days. I don't know if ours do -- the clang build step must use system Xcode, but the chrome build probably should use hermetic Xcode (but I don't know if that's actually true)
(note to self bug 609269, but looks mostly unrelated)

Comment 7 by mattm@chromium.org, Mar 1 2017

That symbol is supposed to exist since 10.7 (https://developer.apple.com/reference/security/ksecpolicyapplessl?language=objc)

Avi also reported a local compile failure with 10.12 sdk in  issue 697615 .

I don't really know whats going on here..
Blockedon: 697615

Comment 9 by h...@chromium.org, Mar 2 2017

Both me and the buildbot are on the 10.10 SDK.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49957feee8c5ea46bc551e669e370164b6852702

commit 49957feee8c5ea46bc551e669e370164b6852702
Author: mattm <mattm@chromium.org>
Date: Thu Mar 02 01:45:29 2017

Mac cert_verify_tool: add Security.framework library dep.

Fixes clang build.

BUG= 697615 , 697603 

Review-Url: https://codereview.chromium.org/2721313003
Cr-Commit-Position: refs/heads/master@{#454142}

[modify] https://crrev.com/49957feee8c5ea46bc551e669e370164b6852702/net/BUILD.gn

Cc: -mattm@chromium.org h...@chromium.org
Owner: mattm@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment