New issue
Advanced search Search tips

Issue 697599 link

Starred by 1 user
Status: Fixed
Owner:
caseq@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Coverage feature feedback

Project Member Reported by paulir...@chromium.org, Mar 1 2017 

1. Reorder columns
  URL | Type | Total Bytes | unused Bytes

2. Add thousands separator to bytes columns

3. inconsistent display URLs for css and JS
see attachment.  Repro on https://chromedevtools.github.io/timeline-viewer/

4. Give enough width to "Type" Column so "Type" isn't elided (Ty…) on first run
Screen Shot 2017-03-01 at 1.12.16 PM.png
231 KB View Download

Comment 1 by pfeldman@chromium.org, Mar 1 2017 

- Use display name instead of URL
- Border around datagrid
- For the files that are loaded multiple times, you are summing up the coverage - those are multiple CSSStyleSheets with the same StyleSheetContent
- remove white border around bars
- render % next to used number or toggle between absolute and percent
- sort by the last column
- right click -> Open (or provide UISourceCode flavor)
- do not recalc style upon start, introduce snapshot later
- consume(true) double click, otherwise selection.

longer term:
- we need protocol to be sane for incremental updates. take should never receive 'unused'
- we should make it live both for css and js (while recording)

Comment 2 by pfeldman@chromium.org, Mar 29 2017 

- Type sort alphabetically
- % Unused, not used
- Sort by the last column remains
- Pretty print for minified
- Reveal upon click.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d5f76795cd8992a4249408bca4f1efc48e79832

commit 6d5f76795cd8992a4249408bca4f1efc48e79832
Author: paulirish <paulirish@chromium.org>
Date: Fri Mar 31 02:38:17 2017

DevTools: Adopt nbsp as unit & thousands separator for broader font support

Helvetica Neue, our current display font on mac, lacks support for &thinsp; -
rendering it without any space at all. The non-breaking space has
approximately the same width and much wider font support.

BUG= 697599 

Review-Url: https://codereview.chromium.org/2781193002
Cr-Commit-Position: refs/heads/master@{#461003}

[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/LayoutTests/http/tests/inspector/network/waterfall-images-expected.txt
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-bottom-up-times-expected.txt
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details-expected.txt
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/6d5f76795cd8992a4249408bca4f1efc48e79832/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Comment 5 by caseq@chromium.org, May 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment