New issue
Advanced search Search tips

Issue 697590 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 508771



Sign in to add a comment

bluetooth: Fix two iframes from same origin test

Project Member Reported by ortuno@chromium.org, Mar 1 2017

Issue description

http://crrev.com/2658473002 introduced a LayoutTests but the test doesn't return any promises so it could never fail.

We need to fix the test.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82200bccb1df8a4a6a9923344b48f80f0b6f2cdd

commit 82200bccb1df8a4a6a9923344b48f80f0b6f2cdd
Author: juncai <juncai@chromium.org>
Date: Fri Mar 03 23:53:10 2017

Fix Web Bluetooth two iframes from same origin layout test

This CL fixes the test:
//third_party/WebKit/LayoutTests/resources/bluetooth/heart-rate-two-iframes.html
which doesn't return any promises so it could never fail.

BUG= 697590 

Review-Url: https://codereview.chromium.org/2729603006
Cr-Commit-Position: refs/heads/master@{#454715}

[modify] https://crrev.com/82200bccb1df8a4a6a9923344b48f80f0b6f2cdd/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/two-iframes-from-same-origin.html
[modify] https://crrev.com/82200bccb1df8a4a6a9923344b48f80f0b6f2cdd/third_party/WebKit/LayoutTests/resources/bluetooth/heart-rate-two-iframes.html

Status: Fixed (was: Started)

Sign in to add a comment