New issue
Advanced search Search tips

Issue 697586 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 670496



Sign in to add a comment

exo::ShellSurface shouldn't use ash::wm::PinWindow

Project Member Reported by penghuang@chromium.org, Mar 1 2017

Issue description

exo::ShellSurface shouldn't use ash::wm::PinWindow, becasue exo isn't allowed to use ash in mustash.
 
Owner: penghuang@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e52cb19f44be5e48c4e34189c2c3d7f3439a4160

commit e52cb19f44be5e48c4e34189c2c3d7f3439a4160
Author: penghuang <penghuang@chromium.org>
Date: Wed Apr 05 00:54:40 2017

Add WindowPinType property on arua::Window

Add WindowPinType property on arua::Window. This property can be used
for requesting pinning a window instead of using ash::wm::PinWindow().

BUG= 697586 

Review-Url: https://codereview.chromium.org/2778733004
Cr-Commit-Position: refs/heads/master@{#461923}

[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/common/wm/default_state.cc
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/common/wm/lock_window_state.cc
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/common/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/common/wm/window_state.cc
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/common/wm/window_state.h
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/common/wm_window.cc
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/mus/window_manager.cc
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/public/cpp/BUILD.gn
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/public/cpp/mus_property_mirror_ash.cc
[add] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/public/cpp/window_pin_type.cc
[add] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/public/cpp/window_pin_type.h
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/public/cpp/window_properties.h
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/public/interfaces/BUILD.gn
[add] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/ash/public/interfaces/window_pin_type.mojom
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/components/exo/shell_surface.cc
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/components/exo/shell_surface.h
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/e52cb19f44be5e48c4e34189c2c3d7f3439a4160/components/exo/wayland/server.cc

Status: Fixed (was: Started)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment