New issue
Advanced search Search tips

Issue 697579 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

arc: Provide more logging for network unavailable faulure

Project Member Reported by khmel@chromium.org, Mar 1 2017

Issue description

Currently network unavailable error is mapped to GMS timeout which makes UMA analyzing bit complicated. There are also several NOTREACHED log records in users' feedbacks.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/337f3e54b359b2b83950d4e61d5c6b05108bc630

commit 337f3e54b359b2b83950d4e61d5c6b05108bc630
Author: khmel <khmel@chromium.org>
Date: Fri Mar 03 03:25:24 2017

arc: Provide more logging for network failures.

This add more loggin for network failures and handles network
timeouts as dedicated UMA entry.

BUG= 697579 
Test=Manually. Emulate network unavailble error. GMS Services error
     is shown. chrome:://histograms shows value 19 recorded. Update
     only ARC side and repeat the test to validate condition with
     mojo different versions. The same error is shown but UMA
     value 14 is recorded in UMA (legacy case)

Review-Url: https://codereview.chromium.org/2723263003
Cr-Commit-Position: refs/heads/master@{#454501}

[modify] https://crrev.com/337f3e54b359b2b83950d4e61d5c6b05108bc630/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/337f3e54b359b2b83950d4e61d5c6b05108bc630/chrome/browser/chromeos/arc/arc_optin_uma.cc
[modify] https://crrev.com/337f3e54b359b2b83950d4e61d5c6b05108bc630/chrome/browser/chromeos/arc/arc_optin_uma.h
[modify] https://crrev.com/337f3e54b359b2b83950d4e61d5c6b05108bc630/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/337f3e54b359b2b83950d4e61d5c6b05108bc630/components/arc/common/auth.mojom
[modify] https://crrev.com/337f3e54b359b2b83950d4e61d5c6b05108bc630/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/337f3e54b359b2b83950d4e61d5c6b05108bc630/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdc90f4b2b62c8e7f8bef55f3293924b6430b0a9

commit fdc90f4b2b62c8e7f8bef55f3293924b6430b0a9
Author: khmel <khmel@chromium.org>
Date: Tue Mar 07 16:45:50 2017

[Merge M57] arc: Provide more logging for network failures.

This add more loggin for network failures and handles network
timeouts as dedicated UMA entry.

NOTRY=true
NOPRESUBMIT=true
TBR=isherman@chromium.org,yusukes@chromium.org,dcheng@chromium.org

BUG= 697579 
Test=Manually. Emulate network unavailble error. GMS Services error
     is shown. chrome:://histograms shows value 19 recorded. Update
     only ARC side and repeat the test to validate condition with
     mojo different versions. The same error is shown but UMA
     value 14 is recorded in UMA (legacy case)

Review-Url: https://codereview.chromium.org/2723263003
Cr-Commit-Position: refs/heads/master@{#454501}
(cherry picked from commit 337f3e54b359b2b83950d4e61d5c6b05108bc630)

Review-Url: https://codereview.chromium.org/2736033003
Cr-Commit-Position: refs/branch-heads/2987@{#786}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/fdc90f4b2b62c8e7f8bef55f3293924b6430b0a9/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/fdc90f4b2b62c8e7f8bef55f3293924b6430b0a9/chrome/browser/chromeos/arc/arc_optin_uma.cc
[modify] https://crrev.com/fdc90f4b2b62c8e7f8bef55f3293924b6430b0a9/chrome/browser/chromeos/arc/arc_optin_uma.h
[modify] https://crrev.com/fdc90f4b2b62c8e7f8bef55f3293924b6430b0a9/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/fdc90f4b2b62c8e7f8bef55f3293924b6430b0a9/components/arc/common/auth.mojom
[modify] https://crrev.com/fdc90f4b2b62c8e7f8bef55f3293924b6430b0a9/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/fdc90f4b2b62c8e7f8bef55f3293924b6430b0a9/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2017

Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66f2e255a9d5e58e26735cb39086aa8302480aa7

commit 66f2e255a9d5e58e26735cb39086aa8302480aa7
Author: khmel <khmel@chromium.org>
Date: Tue Mar 07 16:59:41 2017

[Merge M58] arc: Provide more logging for network failures.

This add more loggin for network failures and handles network
timeouts as dedicated UMA entry.

NOTRY=true
NOPRESUBMIT=true
TBR=isherman@chromium.org,yusukes@chromium.org,dcheng@chromium.org

BUG= 697579 
Test=Manually. Emulate network unavailble error. GMS Services error
     is shown. chrome:://histograms shows value 19 recorded. Update
     only ARC side and repeat the test to validate condition with
     mojo different versions. The same error is shown but UMA
     value 14 is recorded in UMA (legacy case)

Review-Url: https://codereview.chromium.org/2723263003
Cr-Commit-Position: refs/heads/master@{#454501}
(cherry picked from commit 337f3e54b359b2b83950d4e61d5c6b05108bc630)

Review-Url: https://codereview.chromium.org/2735853003
Cr-Commit-Position: refs/branch-heads/3029@{#45}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/66f2e255a9d5e58e26735cb39086aa8302480aa7/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/66f2e255a9d5e58e26735cb39086aa8302480aa7/chrome/browser/chromeos/arc/arc_optin_uma.cc
[modify] https://crrev.com/66f2e255a9d5e58e26735cb39086aa8302480aa7/chrome/browser/chromeos/arc/arc_optin_uma.h
[modify] https://crrev.com/66f2e255a9d5e58e26735cb39086aa8302480aa7/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/66f2e255a9d5e58e26735cb39086aa8302480aa7/components/arc/common/auth.mojom
[modify] https://crrev.com/66f2e255a9d5e58e26735cb39086aa8302480aa7/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/66f2e255a9d5e58e26735cb39086aa8302480aa7/tools/metrics/histograms/histograms.xml

Comment 4 by khmel@chromium.org, Mar 7 2017

Labels: M-58
Status: Fixed (was: Started)
Merge approval is in b/35356475

Comment 5 by ananthak@google.com, Apr 27 2017

Components: Platform>ARC

Sign in to add a comment