New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697573 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Multiline title with big image hides notification content

Reported by ja...@onesignal.com, Mar 1 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Example URL:
https://tests.peter.sh/notification-generator/#title=2;;body=2;;image=1

Steps to reproduce the problem:
Note: This was tested on and affects Windows 10. Mac OS X does not appear to have this issue.

1. Visit https://tests.peter.sh/notification-generator/#title=2;;body=2;;image=1 (be sure to copy the entire URL!). 

2. Confirm the following settings are set:

- Title: Long sentence (anything that causes the title to be multiline)

- Body: Can be one word or a multiline paragraph, enter anything

- Image: The big picture shown below the notification content. Choose any image here.

3.  Click 'Display Notification' and observe the notification missing its body content. It should look like: https://i.imgur.com/apJ2Sma.png

What is the expected behavior?
The notification's title, text, and image should all be displayed.

What went wrong?
On Windows only, it looks like a multiline title with an image hides the notification's body content.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 56.0.2924.87  Channel: stable
OS Version: 10
Flash Version: 

I'm not sure whether this affects other Windows versions; this was only tested on Windows 10.

 

Comment 1 by woxxom@gmail.com, Mar 1 2017

>I'm not sure whether this affects other Windows versions; this was only tested on Windows 10.

On Win7 the title is trimmed and ... is shown for the overflow, see the attached screenshot.
Clip202.png
102 KB View Download
Components: -Blink Blink>PushAPI
Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tested the issue on Win-10 using chrome reported version #56.0.2924.87 and latest canary #58.0.3028.0.

Attached screencast and screenshot for reference.

Following are the steps followed to reproduce the issue.
------------
1. Navigated to https://tests.peter.sh/notification-generator/#title=2;;body=2;;image=1

2. Confirmed the following settings are set:

- Title: Long sentence(LTR)

- Body: Multiple Sentences(LTR)

- Image: CAT photo (JPEG, 3072 x 1728)

3.  Clicked 'Display Notification'.

4. Observed that the notification was shown as in point no.3 of comment #1 i.e https://i.imgur.com/apJ2Sma.png.

Reporter@ - Could you please verify the screen cast and screenshot and please let us know if it is the issue.

Thanks...!!
697573.jpg
26.4 KB View Download
697573.mp4
1001 KB View Download
Components: -Blink>PushAPI UI>Notifications
Labels: -Needs-Feedback OS-Linux
Status: Untriaged (was: Unconfirmed)
Thanks for the report. This does look strange - it seems better to display both a truncated title and a truncated body than just displaying the title.

This also reproduces on Linux 56.0.2924.87.

Comment 5 Deleted

@krajshree, thanks for reproducing this! Yes, the issue is that the notification body is not shown at all while the notification title is shown. Some users were confused because they expected to see some body text.
Status: Available (was: Untriaged)
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 29

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Hotlist-DesktopUIValid Hotlist-DesktopUIChecked
*** UI Mass Triage***

Tested on latest Canary #72.0.3619.0 on Windows 10 and was able to reproduce the issue. Hence, adding appropriate labels.

Note: Issue is also reproduced on M60 builds.

Thanks!

Owner: knollr@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5004f1f273a5b968011f41aad397cb9acfb24979

commit 5004f1f273a5b968011f41aad397cb9acfb24979
Author: Richard Knoll <knollr@chromium.org>
Date: Wed Dec 12 20:40:59 2018

fix: do not remove notification body if image present

If we show a notification with a long title, a context message and an
image, the line limit of the message body is set to 0 so that the image
can be flush against the icon.

This CL removes this limitation and therefore the "feature" of having
the image flush against the icon when the notification contains a lot of
text. The notification message can now contain:

0 title lines: 5 max lines message
1 title lines: 5 max lines message
2 title lines: 3 max lines message

This does not depend on whether there is an image or a context message.
We still make sure that there is at least 16px of space between the icon
and the image, if the text part is higher than the icon.

Bug:  697573 
Change-Id: Ic8f2441de58e4503d93da025275b57ba5a2a92b9
Reviewed-on: https://chromium-review.googlesource.com/c/1350749
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616024}
[modify] https://crrev.com/5004f1f273a5b968011f41aad397cb9acfb24979/ui/message_center/views/notification_view.cc
[modify] https://crrev.com/5004f1f273a5b968011f41aad397cb9acfb24979/ui/message_center/views/notification_view_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment