New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 697570 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
█ wnhuang@chromium.org
adurbin@chromium.org
dnojiri@chromium.org
█ martinroth@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

flashrom called by vpd at boot is slow on Reef/Cave

Project Member Reported by gwendal@chromium.org, Mar 1 2017 
Looking at bootchart graphs, I notice flashrom is slow on Reef/Cave when called by vpd. Both are DVT units, vpd prints the warning message:
"""[WARN] VPD partition not formatted. It's fine."""

vpd is called at 2 places:
1 - in cryptohomed.conf, before starting cryptohome:
  vpd -g stable_device_secret_DO_NOT_SHARE

2 - in check_rw_vpd (called check-rw-vpd.conf)
  vpd_rw_output="$(vpd -i RW_VPD -l)"

See the boot graphs: 
reef: boot-20170301-113827.svg
cave: boot-20170228-154832.svg
note that on veyron, vpd is fast, flashrom does even appears. (boot-20170301-104145.svg)

For 1, the flashrom command sent is:
"flashrom  -p host  -i FMAP -i 'RO_VPD':'/tmp/vpd.flashrom.SnCoH3' -r '/tmp/vpd.flashrom.dV2jl4' >/dev/null 2>&1", it lasts ~1s.

(Using strace -o process_dump -ff -e abbrev=none -s 128 vpd -g stable_device_secret_DO_NOT_SHARE)
boot-20170301-113827.svg
712 KB Download
boot-20170228-154832.svg
549 KB Download
boot-20170301-104145.svg
642 KB Download

Comment 1 by adurbin@chromium.org, Mar 1 2017 

It's likely a function of the flash controller not being very efficient. I believe flashmap has to be located prior to actually dumping out the data. I'm not sure if the search is linear, but it might be. In which case it could take a while to find.

Comment 2 by gwendal@chromium.org, Mar 3 2017

Cc: martinroth@chromium.org

Comment 3 by gkihumba@google.com, Mar 31 2017

Owner: martinroth@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by martinroth@chromium.org, Aug 18 2017

Cc: wnhuang@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 20

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment