New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697562 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 694730



Sign in to add a comment

record exception summary strings from CompoundFailure into CIDB.failureTable.

Project Member Reported by nxia@chromium.org, Mar 1 2017

Issue description

To rebuild build failure message from CIDB.failureTable, we need the exception summary string instead of the full traceback. 


https://cs.corp.google.com/chromeos_public/chromite/cbuildbot/stages/completion_stages.py?sq&q=CreateBuildFailureMessage&l=73

CreateBuildFailureMessage uses exception strings to build msg and reason for failures_lib.BuildFailureMessage
 

Comment 1 by nxia@chromium.org, Mar 1 2017

Summary: record exception summary strings from CompoundFailure into CIDB.failureTable. (was: record exception summary string into CIDB.failureTable.)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/37a876e7ec7819e85c841efea4e62b8211ef1c3d

commit 37a876e7ec7819e85c841efea4e62b8211ef1c3d
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Mar 16 23:15:06 2017

Record CompoundFailure SummaryString into CIDB.failureTable.

In ReportStageFailureToCIDB, for CompoundFailure ex, insert
ex.ToSummaryString instead of str(ex) into
failureTable.exception_message.

BUG= chromium:697562 
TEST=unit_tests

Change-Id: I911bf2942da0416de0a9a0ca1ef7136c18355c8d
Reviewed-on: https://chromium-review.googlesource.com/447833
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/37a876e7ec7819e85c841efea4e62b8211ef1c3d/lib/failures_lib_unittest.py
[modify] https://crrev.com/37a876e7ec7819e85c841efea4e62b8211ef1c3d/lib/failures_lib.py

Comment 3 by nxia@chromium.org, Jun 21 2017

Status: Fixed (was: Untriaged)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment