New issue
Advanced search Search tips

Issue 697557 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove chrome's ImageDecoder API

Project Member Reported by roc...@chromium.org, Mar 1 2017

Issue description

It's an awkward wrapper around the image_decoder client library now and there's probably no reason it needs to stay that way. Good opportunity for some servicificationy code cleanup.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e04370309e452bfdbad223228b908c7e31f2809c

commit e04370309e452bfdbad223228b908c7e31f2809c
Author: rockot <rockot@chromium.org>
Date: Sat Mar 25 02:49:00 2017

image_decoder service -> data_decoder service

Establishes a more generic service definition for a thing to do
sandboxed data decoding. This is just a rename of the existing
image_decoder service.

Since there is nothing Chrome specific about this service, and there is
now some motivation to use sandboxed image decoding outside of Chrome,
this also moves the packaging of the service from chrome into content.

BUG=697557
TBR=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2774463002
Cr-Commit-Position: refs/heads/master@{#459631}

[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/chrome/app/BUILD.gn
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/chrome/browser/BUILD.gn
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/chrome/browser/DEPS
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/chrome/browser/image_decoder.cc
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/chrome/utility/BUILD.gn
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/chrome/utility/DEPS
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/chrome/utility/chrome_content_utility_client.h
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/content/browser/BUILD.gn
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/content/public/app/BUILD.gn
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/content/utility/BUILD.gn
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/content/utility/DEPS
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/content/utility/utility_service_factory.cc
[modify] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/BUILD.gn
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/BUILD.gn
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/DEPS
[add] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/README.md
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/data_decoder_service.cc
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/data_decoder_service.h
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/image_decoder_impl.cc
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/image_decoder_impl.h
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/image_decoder_impl_unittest.cc
[add] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/manifest.json
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/public/cpp/BUILD.gn
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/public/cpp/decode_image.cc
[add] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/public/cpp/decode_image.h
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/public/interfaces/BUILD.gn
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/public/interfaces/OWNERS
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/public/interfaces/constants.mojom
[rename] https://crrev.com/e04370309e452bfdbad223228b908c7e31f2809c/services/data_decoder/public/interfaces/image_decoder.mojom
[delete] https://crrev.com/5adb8c047852670be6c9d42114f3a17d44b6c56e/services/image_decoder/README.md
[delete] https://crrev.com/5adb8c047852670be6c9d42114f3a17d44b6c56e/services/image_decoder/manifest.json
[delete] https://crrev.com/5adb8c047852670be6c9d42114f3a17d44b6c56e/services/image_decoder/public/cpp/decode.h

Comment 2 by roc...@chromium.org, May 29 2017

Cc: roc...@chromium.org
Labels: Proj-Servicification
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 3 by sheriffbot@chromium.org, May 29 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by dxie@chromium.org, May 30 2018

Labels: Hotlist-KnownIssue
Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment