New issue
Advanced search Search tips

Issue 697525 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add support for saving reference file as float wav

Project Member Reported by rtoy@chromium.org, Mar 1 2017 
Currently, when a new reference file is created (using finishAudioTest), the audio buffer is saved as a 16-bit PCM WAV file.  Consider adding support for saving these files as a 32-bit float WAV file for the cases where this makes sense.  (Probably all cases except for the codec tests which normally produce 16-bit results anyway.)

This could simplify some of the tests and can also allow finer-grained testing since the expected result isn't limited to a 16-bit resolution.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0075e99d4cb2cc1e27b396f574f314632a493be

commit a0075e99d4cb2cc1e27b396f574f314632a493be
Author: rtoy <rtoy@chromium.org>
Date: Thu Mar 09 19:21:10 2017

Allow saving reference file as a float32 WAV file

Update the osccilator sweep tests to save the reference file as a
32-bit float WAV result and also update the expected result with this
new file.  The test thresholds are also updated with tighter values,
and we no longer have to deal with the 16-bit aspect of the original
reference files.

BUG= 697525 
TEST=osc-custom-sweep-snr.html, osc-sawtooth-sweep-snr.html, osc-sine-sweep-snr.html, osc-square-sweep-snr.html, osc-triangle-sweep-snr.html

Review-Url: https://codereview.chromium.org/2737653007
Cr-Commit-Position: refs/heads/master@{#455825}

[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-custom-sweep-snr.html
[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sawtooth-sweep-snr.html
[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sine-sweep-snr.html
[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-square-sweep-snr.html
[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-triangle-sweep-snr.html
[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-custom-expected.wav
[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-sawtooth-expected.wav
[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-sine-expected.wav
[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-square-expected.wav
[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-triangle-expected.wav
[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/resources/audit-util.js
[modify] https://crrev.com/a0075e99d4cb2cc1e27b396f574f314632a493be/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js

Comment 2 by rtoy@chromium.org, Mar 10 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment