New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697518 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] flake try job data doesn't exist when monitoring the try job

Project Member Reported by chanli@chromium.org, Mar 1 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/916a710414d46b95dce8caf70adc2769d558c0ca

commit 916a710414d46b95dce8caf70adc2769d558c0ca
Author: Roberto Carrillo <robertocn@google.com>
Date: Wed Mar 01 19:03:02 2017

If the try job data entity does not exist, create it and log an error.

This is to prevent failures caused by the try job data not being created
by the time the pipeline starts monitoring the job.

R=chanli
BUG= 697518 

Change-Id: I67f63f842bf3d7cfb8d00a417b5270fc55490c91
Reviewed-on: https://chromium-review.googlesource.com/447867
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/916a710414d46b95dce8caf70adc2769d558c0ca/appengine/findit/waterfall/monitor_try_job_pipeline.py
[modify] https://crrev.com/916a710414d46b95dce8caf70adc2769d558c0ca/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/40ff8726ba3dd5ddc5b22181301b0ad4dbe348ba

commit 40ff8726ba3dd5ddc5b22181301b0ad4dbe348ba
Author: Chan <chanli@chromium.org>
Date: Wed Mar 08 19:03:52 2017

[Findit] Modify monitor_try_job_pipeline to fix Nonetype error.


BUG= 697518 

Change-Id: I4bcf4ebb323309d49afee1cf5955759650910c3c
Reviewed-on: https://chromium-review.googlesource.com/451600
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/40ff8726ba3dd5ddc5b22181301b0ad4dbe348ba/appengine/findit/waterfall/monitor_try_job_pipeline.py
[modify] https://crrev.com/40ff8726ba3dd5ddc5b22181301b0ad4dbe348ba/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py

Project Member

Comment 3 by sheriffbot@chromium.org, Mar 9 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by st...@chromium.org, Mar 9 2018

Owner: chanli@chromium.org
Status: Assigned (was: Untriaged)
Is this fixed already?
Status: Fixed (was: Assigned)
This should be fixed by the new try-job logic

Sign in to add a comment