List too small when sharing tab only |
|||||||||
Issue descriptionWhen I use the Chrome screen picker for screensharing, if I launch it with settings to only choose from Chrome tabs, the selection window is very small. It only shows 2 tabs in the list at a time, which is problematic if I have a lot of tabs open; I will have to search carefully. A simple improvement would be to make the list show more items.
,
Mar 1 2017
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/866596040a23db3ab4152dba1d41f0a574fc2b83 commit 866596040a23db3ab4152dba1d41f0a574fc2b83 Author: qiangchen <qiangchen@chromium.org> Date: Thu Mar 02 18:41:28 2017 Bug Fix: List Too Small When Sharing Tab Only When the javascript only includes "tab" as source, the source list is too small, and thus inconvenient for users to pick. The reason is that we preset the height too small. In this CL we preset the height larger to a reasonable value. BUG= 697516 Review-Url: https://codereview.chromium.org/2725833003 Cr-Commit-Position: refs/heads/master@{#454317} [modify] https://crrev.com/866596040a23db3ab4152dba1d41f0a574fc2b83/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba4aa7372b68295d0ba4001557e82063c1d90d87 commit ba4aa7372b68295d0ba4001557e82063c1d90d87 Author: qiangchen <qiangchen@chromium.org> Date: Thu Mar 02 18:53:58 2017 Revert of Bug Fix: List Too Small When Sharing Tab Only (patchset #3 id:40001 of https://codereview.chromium.org/2725833003/ ) Reason for revert: A coding style issue Original issue's description: > Bug Fix: List Too Small When Sharing Tab Only > > When the javascript only includes "tab" as source, the source list is too small, and thus inconvenient for users to pick. > > The reason is that we preset the height too small. > > In this CL we preset the height larger to a reasonable value. > > BUG= 697516 > > Review-Url: https://codereview.chromium.org/2725833003 > Cr-Commit-Position: refs/heads/master@{#454317} > Committed: https://chromium.googlesource.com/chromium/src/+/866596040a23db3ab4152dba1d41f0a574fc2b83 TBR=msw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 697516 Review-Url: https://codereview.chromium.org/2731573002 Cr-Commit-Position: refs/heads/master@{#454322} [modify] https://crrev.com/ba4aa7372b68295d0ba4001557e82063c1d90d87/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7af696b5a11fcbdae617d237dbc06aaca6807f94 commit 7af696b5a11fcbdae617d237dbc06aaca6807f94 Author: qiangchen <qiangchen@chromium.org> Date: Thu Mar 02 20:09:01 2017 Reland of Bug Fix: List Too Small When Sharing Tab Only (patchset #1 id:1 of https://codereview.chromium.org/2731573002/ ) Reason for revert: Let's do the fix Original issue's description: > Revert of Bug Fix: List Too Small When Sharing Tab Only (patchset #3 id:40001 of https://codereview.chromium.org/2725833003/ ) > > Reason for revert: > A coding style issue > > Original issue's description: > > Bug Fix: List Too Small When Sharing Tab Only > > > > When the javascript only includes "tab" as source, the source list is too small, and thus inconvenient for users to pick. > > > > The reason is that we preset the height too small. > > > > In this CL we preset the height larger to a reasonable value. > > > > BUG= 697516 > > > > Review-Url: https://codereview.chromium.org/2725833003 > > Cr-Commit-Position: refs/heads/master@{#454317} > > Committed: https://chromium.googlesource.com/chromium/src/+/866596040a23db3ab4152dba1d41f0a574fc2b83 > > TBR=msw@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 697516 > > Review-Url: https://codereview.chromium.org/2731573002 > Cr-Commit-Position: refs/heads/master@{#454322} > Committed: https://chromium.googlesource.com/chromium/src/+/ba4aa7372b68295d0ba4001557e82063c1d90d87 TBR=msw@chromium.org BUG= 697516 Review-Url: https://codereview.chromium.org/2727333002 Cr-Commit-Position: refs/heads/master@{#454359} [modify] https://crrev.com/7af696b5a11fcbdae617d237dbc06aaca6807f94/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
,
Mar 7 2017
,
Mar 7 2017
A simple change.
,
Mar 7 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 8 2017
The revert is just a code style issue, not breaking anything.
,
Mar 9 2017
Please add the OSs for this. Thanks!
,
Mar 9 2017
,
Mar 10 2017
Could you please confirm which CL you're requesting merge for? Also before we approve merge to M58, could you please confirm change is well baked/verified in Canary, having enough automation coverage and will be a safe merge? Thank you.
,
Mar 11 2017
Just noticed, that the CL is already in the M58, so no need to merge.
,
Mar 22 2017
,
Mar 22 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by qiangchen@chromium.org
, Mar 1 201717.1 KB
17.1 KB View Download
25.6 KB
25.6 KB View Download