remote:   https://chromium-review.googlesource.com/447851 CRAS: iodev - Add method to query if a device should mute for volume
remote:   https://chromium-review.googlesource.com/447852 CRAS: iodev_list - Skip ramping if device is muted for volume

Fix posted.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/77fa3d86f29287aa87004c9e1b9abf543f08cd3b

commit 77fa3d86f29287aa87004c9e1b9abf543f08cd3b
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Thu Mar 02 02:42:15 2017

CRAS: iodev_list - Skip ramping if device volume is zero

When adjusted active node volume is zero, or system volume is zero,
samples of a device will be suppressed to zero.
Since the device is already playing zeros, there is no need to ramp down
or up for mute/unmute change.

BUG= chromium:697511 
TEST=on kevin, check there is no extra ramp when pressing volume down
when volume is 0.
TEST=make check

Change-Id: I648fab83f2e6dcfbd2db5370db0509d513d3b40d
Reviewed-on: https://chromium-review.googlesource.com/447852
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/77fa3d86f29287aa87004c9e1b9abf543f08cd3b/cras/src/server/cras_iodev_list.c
[modify] https://crrev.com/77fa3d86f29287aa87004c9e1b9abf543f08cd3b/cras/src/tests/iodev_list_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/82d5f064a97e622eba81ef503b632bac84692024

commit 82d5f064a97e622eba81ef503b632bac84692024
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Thu Mar 02 02:42:15 2017

CRAS: iodev - Add method to query if a device should mute for volume

Add a method to query if a device should mute its samples because
adjusted node volume is zero.
This will be used when cras_iodev_list decides whether it should start
ramping down a device's samples.

BUG= chromium:697511 
TEST=make check

Change-Id: I18b09cba5dc34c8419e0ee17ec7dae9128759731
Reviewed-on: https://chromium-review.googlesource.com/447851
Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/82d5f064a97e622eba81ef503b632bac84692024/cras/src/server/cras_iodev.h
[modify] https://crrev.com/82d5f064a97e622eba81ef503b632bac84692024/cras/src/tests/iodev_unittest.cc
[modify] https://crrev.com/82d5f064a97e622eba81ef503b632bac84692024/cras/src/server/cras_iodev.c

+ketakid@

Hi ketakid@,
I would like to merge these 3 CLs to R57:

https://chromium-review.googlesource.com/c/447851/3
https://chromium-review.googlesource.com/c/448241/2  (there was a typo in bug number so it is not posted to this issue)
https://chromium-review.googlesource.com/c/447852/3

The ramping effect was added to R57 for issue https://bugs.chromium.org/p/chromium/issues/detail?id=669662.
However, the is extra ramp from volume 0 to mute.
The three CL fixed this issue.
Thanks!

This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

IMO this is a release blocker, so I added the label in case we missed it.
Hope this can be merged to R57 soon. Thanks!

Has this been merged to and validated on master for at least a day?

Approving merge to M57.

Thanks!
Verified on image 9344.0 on kevin and chell.
I will merge the CLs.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/76034d1e06570692099db19e4bcff8bbabeffa07

commit 76034d1e06570692099db19e4bcff8bbabeffa07
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Tue Mar 07 03:59:42 2017

CRAS: iodev - Add method to query if a device should mute for volume

Add a method to query if a device should mute its samples because
adjusted node volume is zero.
This will be used when cras_iodev_list decides whether it should start
ramping down a device's samples.

BUG= chromium:697511 
TEST=make check

Change-Id: I18b09cba5dc34c8419e0ee17ec7dae9128759731
Previous-Reviewed-on: https://chromium-review.googlesource.com/447851
(cherry picked from commit 06ddffe0c56d40ee0526aa20733a6f191371ddfe)
Reviewed-on: https://chromium-review.googlesource.com/451057
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/76034d1e06570692099db19e4bcff8bbabeffa07/cras/src/server/cras_iodev.h
[modify] https://crrev.com/76034d1e06570692099db19e4bcff8bbabeffa07/cras/src/tests/iodev_unittest.cc
[modify] https://crrev.com/76034d1e06570692099db19e4bcff8bbabeffa07/cras/src/server/cras_iodev.c

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/a3031fed9e97ece32ceb3c6d64b7fdf46de27b9b

commit a3031fed9e97ece32ceb3c6d64b7fdf46de27b9b
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Tue Mar 07 03:59:44 2017

CRAS: iodev_list - Fix argument of cras_iodev_list_dev_is_enabled

This function queries whether a device is enabled, so it should take a
pointer to const iodev.

BUG= chromium:697511 
TEST=make check

Change-Id: I14f3460089b66059fd0b9315bc0bf79672769827
Previous-Reviewed-on: https://chromium-review.googlesource.com/448241
(cherry picked from commit 52a8ef5b2226521f245d317b4cb3d69a660c1756)
Reviewed-on: https://chromium-review.googlesource.com/451058
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/a3031fed9e97ece32ceb3c6d64b7fdf46de27b9b/cras/src/server/cras_iodev_list.c
[modify] https://crrev.com/a3031fed9e97ece32ceb3c6d64b7fdf46de27b9b/cras/src/server/cras_iodev_list.h
[modify] https://crrev.com/a3031fed9e97ece32ceb3c6d64b7fdf46de27b9b/cras/src/tests/bt_device_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/73554800ebf63aaa977355f7040369f395c7ae53

commit 73554800ebf63aaa977355f7040369f395c7ae53
Author: Cheng-Yi Chiang <cychiang@chromium.org>
Date: Tue Mar 07 03:59:46 2017

CRAS: iodev_list - Skip ramping if device volume is zero

When adjusted active node volume is zero, or system volume is zero,
samples of a device will be suppressed to zero.
Since the device is already playing zeros, there is no need to ramp down
or up for mute/unmute change.

BUG= chromium:697511 
TEST=on kevin, check there is no extra ramp when pressing volume down
when volume is 0.
TEST=make check

Change-Id: I648fab83f2e6dcfbd2db5370db0509d513d3b40d
Previous-Reviewed-on: https://chromium-review.googlesource.com/447852
(cherry picked from commit e4511c6755ad1bb52dcdae5097753ee43e34d518)
Reviewed-on: https://chromium-review.googlesource.com/451077
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/73554800ebf63aaa977355f7040369f395c7ae53/cras/src/server/cras_iodev_list.c
[modify] https://crrev.com/73554800ebf63aaa977355f7040369f395c7ae53/cras/src/tests/iodev_list_unittest.cc

https://chromium-review.googlesource.com/#/c/451057/
https://chromium-review.googlesource.com/#/c/451058/
https://chromium-review.googlesource.com/#/c/451077/
merged to R57.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Verified on build 9202.54.0