New issue
Advanced search Search tips

Issue 697508 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Make "Learn more" button bigger in Page info model

Project Member Reported by olivierrobin@chromium.org, Mar 1 2017

Issue description

Tapping on the button is hard.
Action zone should be bigger.
 
Presumably you mean the security indicator icon?
Summary: Make "Learn more" button bigger in Page info model (was: Make button bigger in Page info model)
I mean the "Learn more" button in the popup.
Updated title
Status: Started (was: Assigned)
Adding screenshot.
The button is the "Learn More" button in the popup.
According to https://developer.apple.com/ios/human-interface-guidelines/visual-design/layout/, minimal size should be 44x44. Today, height is 14.5
Screen Shot 2017-03-02 at 09.30.26.png
148 KB View Download
Here is an after screenshot
after.png
176 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5992cf13afe61e422c8fcff55349f2ad778841e9

commit 5992cf13afe61e422c8fcff55349f2ad778841e9
Author: olivierrobin <olivierrobin@chromium.org>
Date: Fri Mar 03 09:14:50 2017

Make "Learn more" button bigger in the Page Info View.

According to https://developer.apple.com/ios/human-interface-guidelines/visual-design/layout/,
minimal size should be 44x44. Today, height is 14.5, making it hard to tap it.

BUG= 697508 

Review-Url: https://codereview.chromium.org/2729833002
Cr-Commit-Position: refs/heads/master@{#454549}

[modify] https://crrev.com/5992cf13afe61e422c8fcff55349f2ad778841e9/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm

Comment 6 by mea...@chromium.org, Mar 10 2017

Can we close this bug if it's fixed? Thanks.
Status: Fixed (was: Started)

Sign in to add a comment