New issue
Advanced search Search tips

Issue 697496 link

Starred by 1 user

Issue metadata

Status: Closed
Owner: ----
Closed: Jan 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Implement safe library loader

Project Member Reported by kapishnikov@chromium.org, Mar 1 2017

Issue description

Implement and package a safe library loader that can be used by embedders to safely load shared libraries on JB & KK devices. The default library loader can be replaced by calling CronetEngine.Builder.setLibraryLoader(...) method.
 
Status: Available (was: Untriaged)
I'll go ahead and mark this as Available. If anyone has objections, please raise them.
Labels: -Pri-3 Pri-2
I think this is really important.  It turns out few of our embedders are actually calling setLibraryLoader(), but I imagine all of them want to run without crashing on JB and KK devices.  I'm bumping to P2, but am not opposed to bumping to P1.

To implement a solution I think we can resuscitate safe library loader from https://codereview.chromium.org/1216703003 and commit to Cronet directory.

We could add histogram counters to the safe library loader, and when a CronetEngine is actually created take those histogram counters and add their values into the normal histograms collected.

Perhaps we should also deprecate setLibraryLoader as it shouldn't be necessary after this work.
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 6 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Closed (was: Untriaged)
This will not be an issue once Cronet is available from Google Play Services.

Sign in to add a comment