New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697494 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocked on:
issue 666825



Sign in to add a comment

Remove Wheezy Sysroot

Project Member Reported by rsleevi@chromium.org, Mar 1 2017

Issue description

This ended up tripping me up in  Issue 691261  that we have Wheezy sysroot file (//build/linux/sysroot_support), except we no longer support Wheezy ( https://bugs.chromium.org/p/chromium/issues/detail?id=691261#c7 )

We should remove this files so it's clearer.
 
Cc: thestig@chromium.org thomasanderson@chromium.org
Owner: thomasanderson@chromium.org
Status: Assigned (was: Untriaged)
Well, the Wheezy sysroot is what we build against when we run on Precise (i.e., we don't have a Precise sysroot).

While we don't support Chrome on Precise in the wild, we still build on it and are just now (literally, this week) trying to shut down the remaining Precise builders, so I think we can almost get rid of this now.
Owner: sbc@chromium.org
sbc already has a cl open for this waiting to go, so assigning to him
https://codereview.chromium.org/2597523003
Cc: phajdan@google.com

Comment 4 by sbc@chromium.org, Mar 1 2017

Last time I tried to switch to jessie I ran into issues with some bots still being on precise:
https://codereview.chromium.org/2361223002/

Will try gain now.
Blockedon: 666825
There were many, many bots still on precise back then. We have been trying to stamp them out and I think we're down to a half-dozen or so at this point. It's possible that we don't have any that we actually need to build Chrome now. 

We have a few like Goma and some Infra bots that build on Precise specifically to build on Precise, that we may be able to shut down. There's a bunch of CrOS bots left but I don't think they're affected by this (they have their own sysroots/chroots).
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/325bd8b938ccfecfaa698ebb482c5b1cb0337022

commit 325bd8b938ccfecfaa698ebb482c5b1cb0337022
Author: sbc <sbc@chromium.org>
Date: Wed Apr 05 19:36:16 2017

Remove wheezy sysroot images support

We have switched to a debian/jessie sysroot so
wheezy support is not longer needed.

BUG= 697494 

Review-Url: https://codereview.chromium.org/2597523003
Cr-Commit-Position: refs/heads/master@{#462181}

[delete] https://crrev.com/27c6839fb87a7ee23fdf6f0fc8543487f155cbc1/build/linux/sysroot_scripts/debian-archive-wheezy-stable.gpg
[delete] https://crrev.com/27c6839fb87a7ee23fdf6f0fc8543487f155cbc1/build/linux/sysroot_scripts/packagelist.wheezy.amd64
[delete] https://crrev.com/27c6839fb87a7ee23fdf6f0fc8543487f155cbc1/build/linux/sysroot_scripts/packagelist.wheezy.arm
[delete] https://crrev.com/27c6839fb87a7ee23fdf6f0fc8543487f155cbc1/build/linux/sysroot_scripts/packagelist.wheezy.i386
[delete] https://crrev.com/27c6839fb87a7ee23fdf6f0fc8543487f155cbc1/build/linux/sysroot_scripts/packagelist.wheezy.mipsel
[delete] https://crrev.com/27c6839fb87a7ee23fdf6f0fc8543487f155cbc1/build/linux/sysroot_scripts/sysroot-creator-wheezy.sh
[modify] https://crrev.com/325bd8b938ccfecfaa698ebb482c5b1cb0337022/build/linux/sysroot_scripts/sysroots.json
[modify] https://crrev.com/325bd8b938ccfecfaa698ebb482c5b1cb0337022/chrome/installer/linux/BUILD.gn
[modify] https://crrev.com/325bd8b938ccfecfaa698ebb482c5b1cb0337022/chrome/installer/linux/debian/build.sh
[delete] https://crrev.com/27c6839fb87a7ee23fdf6f0fc8543487f155cbc1/chrome/installer/linux/debian/expected_deps_ia32_wheezy
[delete] https://crrev.com/27c6839fb87a7ee23fdf6f0fc8543487f155cbc1/chrome/installer/linux/debian/expected_deps_x64_wheezy
[delete] https://crrev.com/27c6839fb87a7ee23fdf6f0fc8543487f155cbc1/chrome/installer/linux/sysroot_scripts/packagelist.wheezy.mipsel
[modify] https://crrev.com/325bd8b938ccfecfaa698ebb482c5b1cb0337022/docs/linux_chromium_arm.md
[modify] https://crrev.com/325bd8b938ccfecfaa698ebb482c5b1cb0337022/testing/buildbot/trybot_analyze_config.json

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75cc3b096e245801afa0607dc4f8adc03566ae16

commit 75cc3b096e245801afa0607dc4f8adc03566ae16
Author: sbc <sbc@chromium.org>
Date: Mon Apr 10 19:44:17 2017

Refactor target_sysroot_dir gn argument

This change was motivated by the need to remove the
references to wheezy.  I noticed that the target_sysroot_dir
argument could be generalized which avoids the extra
conditional in sysroot.gni.

BUG= 697494 

Review-Url: https://codereview.chromium.org/2810633004
Cr-Commit-Position: refs/heads/master@{#463368}

[modify] https://crrev.com/75cc3b096e245801afa0607dc4f8adc03566ae16/build/config/sysroot.gni

Comment 9 by sbc@chromium.org, Apr 10 2017

Status: Fixed (was: Assigned)

Sign in to add a comment