Issue metadata
Sign in to add a comment
|
Security popup icon is not working from the second time onwards |
||||||||||||||||||||||||
Issue descriptionApp Version: 58.0.3026.0 dev iOS Version: 10.3, 9.3.5 Device: iPhone7, iPad mini URL: any Steps to reproduce: 1. Launch Google Chrome Canary 2. Add any webpage to Reading list 3. Switch to Airplane mode 4. Open the the offline version in a new tab from Reading List 5. Tap on the offline indicator in the omnibox 6. Tap on "Reload" in the security info pop-up 7. Tap on the offline indicator in omnibox again Observed results: No action performed. Expected results: Should display security popup info again. Note: Security info button stopped working for the remaining tabs as well, even after coming to online. Need to force quit the app and launch again inorder to get it working. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M56 NA Bug reproducible on the current beta channel build (App Version, iOS Version): M57.0.2987.85 NO
,
Mar 1 2017
,
Mar 3 2017
Root cause of the bug is a new check added in https://codereview.chromium.org/2672023002
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61f85a6f747a80528881e5e3fa4d12d20325dc4b commit 61f85a6f747a80528881e5e3fa4d12d20325dc4b Author: olivierrobin <olivierrobin@chromium.org> Date: Tue Mar 07 14:18:13 2017 Send IDC_HIDE_PAGE_INFO to close PageInfoView when reloading the page. In M-58+, BVC must be informed if the Page Info controller is dismissed. This is caused by the check added in https://codereview.chromium.org/2672023002 that prevent displaying twice the page info. Use the command to dismiss the popup instead of dismissing it directly. BUG= 697470 Review-Url: https://codereview.chromium.org/2723903005 Cr-Commit-Position: refs/heads/master@{#455067} [modify] https://crrev.com/61f85a6f747a80528881e5e3fa4d12d20325dc4b/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
,
Mar 8 2017
,
Mar 8 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.
,
Mar 15 2017
Verified on 59.0.3042.0 canary Device: iPhone7, iOS: 10.3 beta Security popup is displayed all the times.
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3420248539cc1176ac975d7a87adb67937c7d8a8 commit 3420248539cc1176ac975d7a87adb67937c7d8a8 Author: olivierrobin <olivierrobin@chromium.org> Date: Thu Mar 16 15:33:22 2017 Dismiss popups on Tab deselected Popups are ephemeral views used to send commands. When tab is deselected, they should be dismissed, specially popups relative to the tab (page info). BUG=697506, 697470 Review-Url: https://codereview.chromium.org/2729563003 Cr-Commit-Position: refs/heads/master@{#457442} [modify] https://crrev.com/3420248539cc1176ac975d7a87adb67937c7d8a8/ios/chrome/browser/ui/browser_view_controller.mm
,
Mar 28 2017
,
Mar 28 2017
,
Mar 28 2017
This bug requires manual review: Less than 24 days to go before AppStore submit on M58 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 28 2017
,
Apr 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f713b70e7d259383adabfce8112dbae4200b14f commit 5f713b70e7d259383adabfce8112dbae4200b14f Author: Olivier Robin <olivierrobin@chromium.org> Date: Sat Apr 01 05:31:09 2017 Send IDC_HIDE_PAGE_INFO to close PageInfoView when reloading the page. In M-58+, BVC must be informed if the Page Info controller is dismissed. This is caused by the check added in https://codereview.chromium.org/2672023002 that prevent displaying twice the page info. Use the command to dismiss the popup instead of dismissing it directly. BUG= 697470 Review-Url: https://codereview.chromium.org/2723903005 Cr-Commit-Position: refs/heads/master@{#455067} (cherry picked from commit 61f85a6f747a80528881e5e3fa4d12d20325dc4b) Review-Url: https://codereview.chromium.org/2793773002 . Cr-Commit-Position: refs/branch-heads/3029@{#526} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/5f713b70e7d259383adabfce8112dbae4200b14f/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
,
Apr 5 2017
verified the issue on the latest 58.0.3029.52 beta tested on iPhone(iOS 10). Security icon is tappable from second time works fine. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by srikanthg@chromium.org
, Mar 1 2017