Reconsider how the VR test APKs are obtained on the bots |
|||
Issue descriptionContext: https://codereview.chromium.org/2712733002/ added a hook to download the VR test APKs in all target_os=android chromium checkouts. This was selected over a couple of other options: 1) Adding the hook to the gclient spec for the specific bots. This would have required a modification to bot_update to pass the hooks given to it down to the gclient spec it writes. 2) Modifying the chromium recipe to download the APKs as a separate step on the specific bots. In post-review comments, thakis@ suggested an alternative: 3) have the hook only run if a given environment variable is set, and have the specific bots set that environment variable. cc: folks who have been involved in this discussion at one point or another.
,
Mar 1 2017
Running a hook conditionally based on an environment variable sounds like a fairly good compromise, but is that currently supported?
,
Mar 1 2017
Yes, that's currently supported and is a good suggestion. I should've thought of it the first time, sorry :(.
,
Mar 1 2017
(To be clear, the hook would run always, but it'd early-exit if the env var isn't set.)
,
Mar 2 2017
,
Mar 2 2017
Is there an existing example of this in use? I'm not seeing anything in src/DEPS, and don't see any relevant options in download_from_google_storage or gclient.
,
Mar 2 2017
Look for need_gold_plugin in tools/clang/scripts/update.py for example (it's a pretty big script that does many things, but among other things it downloads a plugin if LLVM_DOWNLOAD_GOLD_PLUGIN is set in the env)
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/1f5346b105dffdf876d30574146165df50effc11 commit 1f5346b105dffdf876d30574146165df50effc11 Author: bsheedy <bsheedy@chromium.org> Date: Fri Mar 03 17:30:35 2017 Add Chromium config option to add env var to download VR APKs Enables the functionality added in https://codereview.chromium.org/2726243002 on 'Android VR Tests' BUG= 697469 Change-Id: Ic1bfcd2a06f0c88e4f8d24e21bc02c7abce432ff Reviewed-on: https://chromium-review.googlesource.com/448708 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@google.com> [modify] https://crrev.com/1f5346b105dffdf876d30574146165df50effc11/scripts/slave/recipe_modules/chromium/config.py [modify] https://crrev.com/1f5346b105dffdf876d30574146165df50effc11/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py [modify] https://crrev.com/1f5346b105dffdf876d30574146165df50effc11/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_VR_Tests.json
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/516f85ba30f7359e8a63eadc0287429f40d877be commit 516f85ba30f7359e8a63eadc0287429f40d877be Author: bsheedy <bsheedy@chromium.org> Date: Fri Mar 03 18:26:28 2017 Move VR test APK downloading behind an env var BUG= 697469 Review-Url: https://codereview.chromium.org/2726243002 Cr-Commit-Position: refs/heads/master@{#454628} [modify] https://crrev.com/516f85ba30f7359e8a63eadc0287429f40d877be/DEPS [add] https://crrev.com/516f85ba30f7359e8a63eadc0287429f40d877be/third_party/gvr-android-sdk/test-apks/update.py
,
Mar 3 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Mar 1 2017