New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 697458 link

Starred by 1 user
Status: Fixed
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Closed: Mar 2017
Cc:
█ dgn@chromium.org
mvanouwe...@chromium.org
peconn@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Snippet title jumps when loading favicons

Project Member Reported by bauerb@chromium.org, Mar 1 2017 
Screenshot: https://screenshot.googleplex.com/9YAnP8BMmxM.png

I think we could set an (invisible?) placeholder in the article view before the favicon loads?

Comment 1 by mvanouwe...@chromium.org, Mar 1 2017

Labels: zine-client-ux
Status: Available (was: Untriaged)
Is this for M58 or M59?
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff1402f96bc21441eb7a8950d44adac9e67622ee

commit ff1402f96bc21441eb7a8950d44adac9e67622ee
Author: dgn <dgn@chromium.org>
Date: Wed Mar 01 19:11:18 2017

[NTP Client] Initialise suggestion cards favicon space

This reserves the space to be occupied by the favicon once
it the callback getting it from the local storage returns.
This avoid the text from being visibly pushed out while on
screen.

BUG= 697458 

Review-Url: https://codereview.chromium.org/2725873003
Cr-Commit-Position: refs/heads/master@{#453990}

[modify] https://crrev.com/ff1402f96bc21441eb7a8950d44adac9e67622ee/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Comment 3 by mvanouwe...@chromium.org, Mar 2 2017

Labels: M-58
Owner: dgn@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment