New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697454 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

log core page load metrics in UKM

Project Member Reported by bmcquade@chromium.org, Mar 1 2017

Issue description

With the introduction of the new UKM client API (https://codereview.chromium.org/2704373003) we should start logging core page load metrics in UKM.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/117fb7823a566d83abc3db2d6f1cd06825e67d03

commit 117fb7823a566d83abc3db2d6f1cd06825e67d03
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Mar 02 15:20:52 2017

Convert first contentful paint logging to the new UKM client API

This change switches FCP logging from the Source proto to the new
UKM client API.

This change also does the following:
* extends the UKM test infrastructure slightly, in order to enable testing
  of metrics that use thew new client API.
* renames committed_url to url in the client-side code, to match the proto
* stops populating the first_contentful_paint source field and marks it as
  deprecated, as FCP is now recorded using the new client API.

BUG= 697454 

Review-Url: https://codereview.chromium.org/2719823003
Cr-Commit-Position: refs/heads/master@{#454262}

[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/components/metrics/proto/ukm/source.proto
[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/components/ukm/test_ukm_service.cc
[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/components/ukm/test_ukm_service.h
[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/components/ukm/ukm_entry.cc
[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/components/ukm/ukm_entry.h
[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/components/ukm/ukm_service.cc
[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/components/ukm/ukm_service.h
[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/components/ukm/ukm_source.cc
[modify] https://crrev.com/117fb7823a566d83abc3db2d6f1cd06825e67d03/components/ukm/ukm_source.h

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c68311a3f7c731ecf774e4ac411bbd2179436fb

commit 8c68311a3f7c731ecf774e4ac411bbd2179436fb
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Mar 02 18:12:56 2017

Add additional PageLoad UKM metrics using new UKM client API.

This change adds core PageLoad metrics to UKM. The new metrics are:
* first meaningful paint (experimental)
* foreground duration
* parse start
* dom content loaded
* load event

BUG= 697454 

Review-Url: https://codereview.chromium.org/2727143004
Cr-Commit-Position: refs/heads/master@{#454308}

[modify] https://crrev.com/8c68311a3f7c731ecf774e4ac411bbd2179436fb/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/8c68311a3f7c731ecf774e4ac411bbd2179436fb/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/8c68311a3f7c731ecf774e4ac411bbd2179436fb/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment