New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697453 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

testActionsPersistAfterSamePageNavigation is flaky

Project Member Reported by zqzh...@chromium.org, Mar 1 2017

Issue description

Status: Assigned (was: Untriaged)
NotificationTitleUpdatedTest#testMediaMetadataPersistsAfterSamePageNavigation is flaky as well, should be the same cause.
Cc: zqzh...@chromium.org jam@chromium.org
 Issue 697467  has been merged into this issue.
Some data (stack etc) from the dupe:

org.chromium.chrome.browser.media.ui.NotificationActionsUpdatedTest#testActionsPersistAfterSamePageNavigation failing on 7.5% of linux_android_rel_ng runs, slowing CQ	

Example: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/241836

org.chromium.chrome.browser.media.ui.NotificationActionsUpdatedTest#testActionsPersistAfterSamePageNavigation (run #1):
java.lang.RuntimeException: Exception occured while waiting for runnable
	at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:79)
	at org.chromium.chrome.browser.media.ui.NotificationActionsUpdatedTest.assertActionsMatch(NotificationActionsUpdatedTest.java:135)
	at org.chromium.chrome.browser.media.ui.NotificationActionsUpdatedTest.testActionsPersistAfterSamePageNavigation(NotificationActionsUpdatedTest.java:87)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:752)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
Caused by: java.util.concurrent.ExecutionException: junit.framework.AssertionFailedError: expected:<[0, 1]> but was:<[]>
	at java.util.concurrent.FutureTask.report(FutureTask.java:93)
	at java.util.concurrent.FutureTask.get(FutureTask.java:163)
	at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:77)
	... 19 more
Caused by: junit.framework.AssertionFailedError: expected:<[0, 1]> but was:<[]>
	at org.chromium.chrome.browser.media.ui.NotificationActionsUpdatedTest$4.run(NotificationActionsUpdatedTest.java:143)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:422)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5001)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
	at dalvik.system.NativeStart.main(Native Method)


15 of the last 200 tasks on https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng?numbuilds=200 failed due to this, so this has significant impact on the CQ.


 Bug 674304  suggests this might be related to plznavigate -- did we turn that on by default recently or something? (jam?)

Or maybe it's just due to one of zqzhang's recent changes to that file.

Comment 4 by jam@chromium.org, Mar 1 2017

674304 is failures with plznavigate enabled, but it's not enabled yet.
I found the following in the logcat:
[0301/152950.249107:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /content/test/data/simple_page.html

So the test server responses 404 for the test page.
We need to add the test pages to the data attribute for `chrome_test_java` in BUILD.gn:
https://cs.chromium.org/chromium/src/chrome/android/BUILD.gn?rcl=7e037f88dbb6095e3db1fe6f166fc68355bc5cd1&l=457
 Issue 697492  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/778f0744fecc3c50d4d23b0df97e3eaef9cbf817

commit 778f0744fecc3c50d4d23b0df97e3eaef9cbf817
Author: zqzhang <zqzhang@chromium.org>
Date: Wed Mar 01 19:12:36 2017

Fix two flaky media notification tests

There are two media notification tests flaky because of the test
pages are not set properly in BUILD.gn. This CL adds two test
pages in `media/session` test data directory so that they are
copied onto the device as they are executed. The `media/session`
test data directory is already in BUILD.gn so no changes there
needed.

BUG= 697453 

Review-Url: https://codereview.chromium.org/2722233002
Cr-Commit-Position: refs/heads/master@{#453991}

[modify] https://crrev.com/778f0744fecc3c50d4d23b0df97e3eaef9cbf817/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java
[modify] https://crrev.com/778f0744fecc3c50d4d23b0df97e3eaef9cbf817/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
[add] https://crrev.com/778f0744fecc3c50d4d23b0df97e3eaef9cbf817/content/test/data/media/session/title1.html
[add] https://crrev.com/778f0744fecc3c50d4d23b0df97e3eaef9cbf817/content/test/data/media/session/title2.html

Status: Started (was: Assigned)
It should be fixed now. I'll watch the flakiness dashboard for a couple of days and close the issue if the tests are no longer flaky.
Status: Fixed (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 4 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/739dd695c7e6b6481b97ecf6e0b5e8ee63a75f83

commit 739dd695c7e6b6481b97ecf6e0b5e8ee63a75f83
Author: Zhiqiang Zhang <zqzhang@google.com>
Date: Sat Mar 04 13:26:51 2017

Fix two flaky media notification tests

There are two media notification tests flaky because of the test
pages are not set properly in BUILD.gn. This CL adds two test
pages in `media/session` test data directory so that they are
copied onto the device as they are executed. The `media/session`
test data directory is already in BUILD.gn so no changes there
needed.

BUG= 697453 

Review-Url: https://codereview.chromium.org/2722233002
Cr-Commit-Position: refs/heads/master@{#453991}
(cherry picked from commit 778f0744fecc3c50d4d23b0df97e3eaef9cbf817)

Review-Url: https://codereview.chromium.org/2731153002 .
Cr-Commit-Position: refs/branch-heads/2987@{#764}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/739dd695c7e6b6481b97ecf6e0b5e8ee63a75f83/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java
[modify] https://crrev.com/739dd695c7e6b6481b97ecf6e0b5e8ee63a75f83/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
[add] https://crrev.com/739dd695c7e6b6481b97ecf6e0b5e8ee63a75f83/content/test/data/media/session/title1.html
[add] https://crrev.com/739dd695c7e6b6481b97ecf6e0b5e8ee63a75f83/content/test/data/media/session/title2.html

Sign in to add a comment