Selection.addRange console output can be confusing |
||||||
Issue descriptionhttps://twitter.com/kdzwinel/status/836932012053303296 Selection.addRange reports a console ERROR: "The given range isn't in the document" and apparently this developer was disappointed they couldn't catch the exception to silence the warning. Perhaps we should always use 'warning' level for such messages, not 'error'?
,
Mar 2 2017
No-exception is defined by the Selection API specification, and changing the specification for throwing would not be reasonable because no browsers throw at this moment. What we should do: - Error -> Warning - Improve the message so that users can know it is shown by Selection.addRange.
,
Nov 13 2017
,
Nov 14
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 15
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ada1a56e19efbc88c532ba3862d3ad1fa62ce3e1 commit ada1a56e19efbc88c532ba3862d3ad1fa62ce3e1 Author: Kent Tamura <tkent@chromium.org> Date: Thu Nov 15 07:20:14 2018 Change the level of Selection.addRange failure message. Error -> Warning. Bug: 697443 Change-Id: Ib4e88bb64cd5f1a533ae88306c47e91ca0606085 Reviewed-on: https://chromium-review.googlesource.com/c/1337216 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#608284} [modify] https://crrev.com/ada1a56e19efbc88c532ba3862d3ad1fa62ce3e1/third_party/WebKit/LayoutTests/editing/selection/addRange-failures-expected.txt [modify] https://crrev.com/ada1a56e19efbc88c532ba3862d3ad1fa62ce3e1/third_party/blink/renderer/core/editing/dom_selection.cc [modify] https://crrev.com/ada1a56e19efbc88c532ba3862d3ad1fa62ce3e1/third_party/blink/renderer/core/editing/dom_selection.h
,
Nov 15
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kdzwinel@gmail.com
, Mar 1 2017