New issue
Advanced search Search tips

Issue 697423 link

Starred by 1 user
Status: Fixed
Owner:
pmarko@chromium.org
Closed: Mar 2017
Cc:
alemate@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename LRU Input Method to Last Input Method

Project Member Reported by pmarko@chromium.org, Mar 1 2017 
We use the term "LRU" with Input Methods in the context of storing the input method last used by the user.
/src/chrome/common/pref_names{.h|.cc}
/src/chrome/browser/chromeos/input_method/input_method_persistence{.h|.cc}
/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler{.h|.cc}

This is confusing as we are storing the Last = Most Recently Used input method, NOT the least recently used input method.

These should be renamed to "Last" (after offline discussion with alemate).
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90fcce75b3610cad4332d51460504dc3f015abc7

commit 90fcce75b3610cad4332d51460504dc3f015abc7
Author: pmarko <pmarko@chromium.org>
Date: Fri Mar 03 14:56:33 2017

Rename LRU Input Method to Last Input Method

Change the naming of last input methods stored for users from LRU to
Last, because LRU is confusing in this context as it suggest that the
least recently used input method is stored.

BUG= 697423 
TEST=browser_tests --gtest_filter=LoginUIKeyboard*

Review-Url: https://codereview.chromium.org/2723083003
Cr-Commit-Position: refs/heads/master@{#454580}

[modify] https://crrev.com/90fcce75b3610cad4332d51460504dc3f015abc7/chrome/browser/chromeos/input_method/input_method_persistence.cc
[modify] https://crrev.com/90fcce75b3610cad4332d51460504dc3f015abc7/chrome/browser/chromeos/input_method/input_method_persistence.h
[modify] https://crrev.com/90fcce75b3610cad4332d51460504dc3f015abc7/chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc
[modify] https://crrev.com/90fcce75b3610cad4332d51460504dc3f015abc7/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/90fcce75b3610cad4332d51460504dc3f015abc7/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/90fcce75b3610cad4332d51460504dc3f015abc7/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
[modify] https://crrev.com/90fcce75b3610cad4332d51460504dc3f015abc7/chrome/common/pref_names.cc
[modify] https://crrev.com/90fcce75b3610cad4332d51460504dc3f015abc7/chrome/common/pref_names.h
[modify] https://crrev.com/90fcce75b3610cad4332d51460504dc3f015abc7/components/policy/resources/policy_templates.json

Comment 2 by pmarko@chromium.org, Mar 3 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment