Issue 697390 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	thestig@chromium.org
Closed:	Mar 2017
Cc:	xiy...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
Stability-Memory-MemorySanitizer VerifyIn-59 VerifyIn-60 VerifyIn-61

ChromeOS MSAN errors in TraceStackFramePointers()

Project Member Reported by thestig@chromium.org, Mar 1 2017

Issue description

On https://build.chromium.org/p/chromium.memory.full/builders/Linux%20ChromeOS%20MSan%20Tests/builds/5540

CloseTrackingTest and many browser_tests fail with stacks similar to:

MemorySanitizer: use-of-uninitialized-value
    #0 0x133421f9 in IsStackFrameValid base/debug/stack_trace.cc:73:9
    #1 0x133421f9 in TraceStackFramePointers base/debug/stack_trace.cc:245:0
    #2 0xeea921f in CloseOverride chrome/browser/chromeos/libc_close_tracking.cc:127:9
    #3 0x13396c9e in Free base/files/scoped_file.cc:32:13

This is triggered by the code from r442604. It looks like TraceStackFramePointers() confuses MSAN, which is why StackTraceTest.TraceStackFramePointers is disabled under MSAN.

Comment 1 by thestig@chromium.org, Mar 1 2017

https://codereview.chromium.org/2723063002

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d79662e1eae0b35104c93f7356b7077cfc0f3202

commit d79662e1eae0b35104c93f7356b7077cfc0f3202
Author: thestig <thestig@chromium.org>
Date: Wed Mar 01 17:15:19 2017

ChromeOS: Do not use TraceStackFramePointers() with MSAN.

BUG= 697390 

Review-Url: https://codereview.chromium.org/2723063002
Cr-Commit-Position: refs/heads/master@{#453957}

[modify] https://crrev.com/d79662e1eae0b35104c93f7356b7077cfc0f3202/chrome/browser/chromeos/libc_close_tracking.cc