Deprecate URLSearchParams construction from another URLSearchParams |
|||
Issue descriptionIt has been removed from the spec in https://github.com/whatwg/url/pull/175
,
Jun 23 2017
intent to ship email sent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AGyufsf5XU4/CBeVLmT7BgAJ
,
Jun 23 2017
What's the relationship between this bug and issue 680531 ? Does it make sense to do one without the other, or are they really the same thing?
,
Jun 25 2017
I wasn't aware of that bug, thanks for pointing it out. While strictly speaking that one is about supporting records and this one is about dropping URLSearchParams from the union, the fix ends up being the same so I've assigned both bugs to myself.
,
Jun 26 2017
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e6727773d5da351bc6eb887dc491cc599c9e6d7 commit 8e6727773d5da351bc6eb887dc491cc599c9e6d7 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Tue Jun 27 10:12:39 2017 url: Update URLSearchParams' constructor arguments. Adapt to https://github.com/whatwg/url/pull/175, which dropped URLSearchParams itself from the union accepted by the constructor. The constructor now takes an optional (sequence<sequence<USVString>> or record<USVString, USVString> or USVString) instead. Existing uses of `new URLSearchParams(<existing URLSearchParam>)` continue to work, as per WebIDL these objects are converted to sequences because URLSearchParams is iterable. Intent to ship/implement thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AGyufsf5XU4/CBeVLmT7BgAJ Bug: 680531 , 697378 Change-Id: Ie82d1151acc4334628be0cc258bc20e5a0dc1d15 Reviewed-on: https://chromium-review.googlesource.com/544919 Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#482588} [modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/LayoutTests/external/wpt/url/urlsearchparams-constructor-expected.txt [modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/LayoutTests/fast/domurl/urlsearchparams-constructor.html [modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/Source/bindings/core/v8/BUILD.gn [modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/Source/core/dom/URLSearchParams.cpp [modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/Source/core/dom/URLSearchParams.h [modify] https://crrev.com/8e6727773d5da351bc6eb887dc491cc599c9e6d7/third_party/WebKit/Source/core/dom/URLSearchParams.idl
,
Jun 27 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by raphael....@intel.com
, Jun 22 2017Status: Started (was: Available)