New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697353 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 671375



Sign in to add a comment

Regression:Unable to click checkbox on first instance in add language list.

Reported by vku...@etouch.net, Mar 1 2017

Issue description

Chrome Version: 57.0.2987.88 (Official Build)Revision 25c30d3a5092ae3e64707cc8a56e10c653d4fa4d-refs/branch-heads/2987@{#728} (32/64 Bit)
OS:Windows (7,8,8.1,10)

What steps will reproduce the problem?
(1)Freshly launch chrome and navigate to chrome://md-settings/
(2)Click on 'Advanced' > Language > Add languages such that list appears.
(3)Now scroll down and click on 'French' checkbox observe.

Actual: Unable to click checkbox on first instance in add language list.

Expected: Should be able to click checkbox on first instance.

This is a regression issue broken in 'M54' and below is the manual regression range
Good Build: 54.0.2839.0
Bad Build:  54.0.2840.0

Note: Issue not seen on Mac & Linux OS.
 
Actual_Lang.mp4
521 KB View Download
Expected_Lang.mp4
527 KB View Download
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: michae...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 54.0.2839.0 (Revision: 414243).
Bad build: 54.0.2840.0 (Revision: 414607).

You are probably looking for a change made after 414245 (known good), but no later than 414246 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/449e2fc928a4a579182f6f49f4defbfcec2b1c4c..9a670d48822912050a3c06bf1f3afb1a01c1e0a3

From the CL above, assigning the issue to the concern owner

@michaelpg : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2265253002
Note :Able to reproduce the issue in Ubuntu 14.04,Win 10.0 and Mac 10.12.3 and Able to reproduce in latest Canary #58.0.3027.0
Cc: dbeam@chromium.org michae...@chromium.org hcarmona@chromium.org
Owner: dbeam@chromium.org
Status: Untriaged (was: Assigned)
gah, more iron-list bugs. dbeam@ can you triage -- is this something we've seen before? if not, someone still working on Settings who's familiar with iron-list and/or dialogs should probably take a look.

It's possible this is triggered by the focus() behavior in add_languages_dialog.js, but that wouldn't match the regression range.

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/languages_page/add_languages_dialog.js?type=cs&q=focus+file:language+file:settings&sq=package:chromium&l=54

Comment 3 by dbeam@chromium.org, Mar 6 2017

Blocking: 671375
Labels: -Pri-2 -M-57 Pri-1
Owner: scottchen@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
From initial triaging, there's only a few languages checkboxes that does this. I found so far "Chinese (Simplified)", "Hungarian", "French" would do this. 

Pretty sure this odd behavior is related: If you scroll to somewhere near one of these languages and check another language, you'll notice a quick blink of a focus ripple around the checkbox of one of the aforementioned language.

For example: Open the add language dialog, scroll down such that both "Chinese" and "Chinese (simplified)" are visible. Check the "Chinese" checkbox while staring at the "Chinese (simplified)" checkbox, and you'll see a flash of ripple around the "Chinese (simplified)" checkbox.

My first guess is how iron-list lazily load the items - will keep triaging.

Comment 6 Deleted

It looks like the problem is most likely related to how iron-list lazily loads 20 items at a time - it seems like the problematic check-boxes are always the last of them 20-item batch in the dom. 
Also just noticed that the "tap" event doesn't even trigger for the element on first interaction, so it smells like the element's not added into the DOM correctly somehow.
For more context, the aforementioned languages that have issues is under the assumption that "English" and "English (United States)" are your only added languages. Otherwise, you might see issues with a whole different subset.
Was able to reproduce the issue with minimal repro step in a fiddle:
https://jsfiddle.net/cyenptb4/7/

and have filed an issue here: https://github.com/PolymerElements/iron-list/issues/411

The pattern seems to be consistent with my previous guess that every first item of the lazily loaded batch displays this problematic behavior.

I haven't found which part of the code is causing this issue, nor a workaround yet. Will keep looking into it.
Labels: Proj-MaterialDesign-WebUI
Labels: Hotlist-MD-Settings-Languages
Status: Fixed (was: Started)

Sign in to add a comment