Regression:Unable to click checkbox on first instance in add language list.
Reported by
vku...@etouch.net,
Mar 1 2017
|
|||||||
Issue descriptionChrome Version: 57.0.2987.88 (Official Build)Revision 25c30d3a5092ae3e64707cc8a56e10c653d4fa4d-refs/branch-heads/2987@{#728} (32/64 Bit) OS:Windows (7,8,8.1,10) What steps will reproduce the problem? (1)Freshly launch chrome and navigate to chrome://md-settings/ (2)Click on 'Advanced' > Language > Add languages such that list appears. (3)Now scroll down and click on 'French' checkbox observe. Actual: Unable to click checkbox on first instance in add language list. Expected: Should be able to click checkbox on first instance. This is a regression issue broken in 'M54' and below is the manual regression range Good Build: 54.0.2839.0 Bad Build: 54.0.2840.0 Note: Issue not seen on Mac & Linux OS.
,
Mar 6 2017
gah, more iron-list bugs. dbeam@ can you triage -- is this something we've seen before? if not, someone still working on Settings who's familiar with iron-list and/or dialogs should probably take a look. It's possible this is triggered by the focus() behavior in add_languages_dialog.js, but that wouldn't match the regression range. https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/languages_page/add_languages_dialog.js?type=cs&q=focus+file:language+file:settings&sq=package:chromium&l=54
,
Mar 6 2017
,
Mar 6 2017
,
Mar 6 2017
From initial triaging, there's only a few languages checkboxes that does this. I found so far "Chinese (Simplified)", "Hungarian", "French" would do this. Pretty sure this odd behavior is related: If you scroll to somewhere near one of these languages and check another language, you'll notice a quick blink of a focus ripple around the checkbox of one of the aforementioned language. For example: Open the add language dialog, scroll down such that both "Chinese" and "Chinese (simplified)" are visible. Check the "Chinese" checkbox while staring at the "Chinese (simplified)" checkbox, and you'll see a flash of ripple around the "Chinese (simplified)" checkbox. My first guess is how iron-list lazily load the items - will keep triaging.
,
Mar 6 2017
It looks like the problem is most likely related to how iron-list lazily loads 20 items at a time - it seems like the problematic check-boxes are always the last of them 20-item batch in the dom.
,
Mar 6 2017
Also just noticed that the "tap" event doesn't even trigger for the element on first interaction, so it smells like the element's not added into the DOM correctly somehow.
,
Mar 6 2017
For more context, the aforementioned languages that have issues is under the assumption that "English" and "English (United States)" are your only added languages. Otherwise, you might see issues with a whole different subset.
,
Mar 7 2017
Was able to reproduce the issue with minimal repro step in a fiddle: https://jsfiddle.net/cyenptb4/7/ and have filed an issue here: https://github.com/PolymerElements/iron-list/issues/411 The pattern seems to be consistent with my previous guess that every first item of the lazily loaded batch displays this problematic behavior. I haven't found which part of the code is causing this issue, nor a workaround yet. Will keep looking into it.
,
Mar 8 2017
,
Mar 13 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/262914424bb02c970d5593c9f66d8f2657d022ff commit 262914424bb02c970d5593c9f66d8f2657d022ff Author: dbeam <dbeam@chromium.org> Date: Thu Mar 16 04:04:29 2017 Closure: remove pending_compiler_externs.js The only thing they provided is already inside of compiler.jar's externs.zip/browser/html5.js at this point (HTMLImportElement#import). R=tbreisacher@chromium.org BUG= 697353 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2754733002 Cr-Commit-Position: refs/heads/master@{#457345} [modify] https://crrev.com/262914424bb02c970d5593c9f66d8f2657d022ff/third_party/closure_compiler/externs/compiled_resources2.gyp [delete] https://crrev.com/880b3a975ba7d0a4eda16332bcb8bac63f561405/third_party/closure_compiler/externs/pending_compiler_externs.js [modify] https://crrev.com/262914424bb02c970d5593c9f66d8f2657d022ff/third_party/closure_compiler/tools/create_include_gyp.py [modify] https://crrev.com/262914424bb02c970d5593c9f66d8f2657d022ff/ui/webui/resources/js/compiled_resources.gyp [modify] https://crrev.com/262914424bb02c970d5593c9f66d8f2657d022ff/ui/webui/resources/js/compiled_resources2.gyp
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e099d4c84b02fe2a6ee52883090a974ceb8cfd1 commit 9e099d4c84b02fe2a6ee52883090a974ceb8cfd1 Author: scottchen <scottchen@chromium.org> Date: Thu Mar 16 08:49:04 2017 MD Settings: bump iron-list version. Primarily to address an issue we're seeing in Settings where initial clicks on certain row items aren't being registered. BUG= 697353 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2751523005 Cr-Commit-Position: refs/heads/master@{#457373} [modify] https://crrev.com/9e099d4c84b02fe2a6ee52883090a974ceb8cfd1/third_party/polymer/v1_0/bower.json [modify] https://crrev.com/9e099d4c84b02fe2a6ee52883090a974ceb8cfd1/third_party/polymer/v1_0/components-chromium/iron-list/bower.json [modify] https://crrev.com/9e099d4c84b02fe2a6ee52883090a974ceb8cfd1/third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js [modify] https://crrev.com/9e099d4c84b02fe2a6ee52883090a974ceb8cfd1/third_party/polymer/v1_0/components-chromium/iron-list/iron-list.html [modify] https://crrev.com/9e099d4c84b02fe2a6ee52883090a974ceb8cfd1/third_party/polymer/v1_0/components_summary.txt
,
Mar 16 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rbasuvula@chromium.org
, Mar 1 2017Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: michae...@chromium.org
Status: Assigned (was: Unconfirmed)