New issue
Advanced search Search tips

Issue 697351 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename platform/Widget to platform/FrameViewBase.

Project Member Reported by joelhockey@chromium.org, Mar 1 2017

Issue description

This Widget is a totally different concept than RenderWidget / WebWidget. The Widget is used just as a base class for FrameView, Scrollbar and PluginView.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77d29a88d7a2292838afe8bbd0a48fb2546fc484

commit 77d29a88d7a2292838afe8bbd0a48fb2546fc484
Author: joelhockey <joelhockey@chromium.org>
Date: Wed Mar 01 09:25:22 2017

Part 1 to rename platform/Widget to platform/FrameViewBase.

Rename Widget to FrameViewBase but leave 'using Widget = FrameViewBase' in Widget.h.
Minimum other changes made to other classes that are using forward declarations.
Following CLs will change clients from importing and using Widget.h to use
FrameViewBase.h

BUG= 697351 

Review-Url: https://codereview.chromium.org/2722953003
Cr-Commit-Position: refs/heads/master@{#453894}

[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/bindings/core/v8/ScriptController.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/core/html/HTMLPlugInElement.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/core/html/PluginDocument.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/platform/FrameViewBase.cpp
[add] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/platform/FrameViewBase.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/platform/HostWindow.h
[delete] https://crrev.com/ff3ad9a544321a740a585329d624ad78b4c6c551/third_party/WebKit/Source/platform/Widget.cpp
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/platform/Widget.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/platform/scroll/ScrollbarThemeClient.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/web/WebInputEventConversion.h
[modify] https://crrev.com/77d29a88d7a2292838afe8bbd0a48fb2546fc484/third_party/WebKit/Source/web/WebPluginContainerImpl.h

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fc16527fa8b8e3366213bc6038882135f431935

commit 5fc16527fa8b8e3366213bc6038882135f431935
Author: joelhockey <joelhockey@chromium.org>
Date: Wed Mar 01 11:42:23 2017

Rename platform/Widget to platform/FrameViewBase in modules.

BUG= 697351 

Review-Url: https://codereview.chromium.org/2728613002
Cr-Commit-Position: refs/heads/master@{#453907}

[modify] https://crrev.com/5fc16527fa8b8e3366213bc6038882135f431935/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3bc614272b3065544777ce45f740e526ab41c6c

commit e3bc614272b3065544777ce45f740e526ab41c6c
Author: joelhockey <joelhockey@chromium.org>
Date: Wed Mar 01 12:07:22 2017

Rename platform/Widget to platform/FrameViewBase in core.

BUG= 697351 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2723993002
Cr-Commit-Position: refs/heads/master@{#453912}

[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/frame/RemoteFrameView.h
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/frame/RootFrameViewport.h
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/frame/VisualViewport.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/frame/VisualViewport.h
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/html/PluginDocument.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/layout/LayoutPart.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/layout/LayoutPart.h
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/layout/LayoutScrollbar.h
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/paint/PartPainter.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/plugins/PluginView.h
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp
[modify] https://crrev.com/e3bc614272b3065544777ce45f740e526ab41c6c/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef1fe9bcedcee99abce0a73583db086d15631b1b

commit ef1fe9bcedcee99abce0a73583db086d15631b1b
Author: joelhockey <joelhockey@chromium.org>
Date: Wed Mar 01 12:17:43 2017

Rename platform/Widget to platform/FrameViewBase in web.

BUG= 697351 

Review-Url: https://codereview.chromium.org/2729543002
Cr-Commit-Position: refs/heads/master@{#453916}

[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/LocalFrameClientImpl.h
[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/WebInputEventConversion.h
[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/WebNode.cpp
[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/WebPluginContainerImpl.h
[modify] https://crrev.com/ef1fe9bcedcee99abce0a73583db086d15631b1b/third_party/WebKit/Source/web/WebViewImpl.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84b4215d6c4fa677341ba96dfdfa083a27345b74

commit 84b4215d6c4fa677341ba96dfdfa083a27345b74
Author: joelhockey <joelhockey@chromium.org>
Date: Wed Mar 01 12:20:58 2017

Rename platform/Widget to platform/FrameViewBase in bindings.

BUG= 697351 

Review-Url: https://codereview.chromium.org/2726833002
Cr-Commit-Position: refs/heads/master@{#453917}

[modify] https://crrev.com/84b4215d6c4fa677341ba96dfdfa083a27345b74/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45fac28e06443491e5764ef44f3136dbcd0efb54

commit 45fac28e06443491e5764ef44f3136dbcd0efb54
Author: joelhockey <joelhockey@chromium.org>
Date: Thu Mar 02 00:10:21 2017

Rename platform/Widget to platform/FrameViewBase in platform.

BUG= 697351 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2721133003
Cr-Commit-Position: refs/heads/master@{#454110}

[modify] https://crrev.com/45fac28e06443491e5764ef44f3136dbcd0efb54/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
[modify] https://crrev.com/45fac28e06443491e5764ef44f3136dbcd0efb54/third_party/WebKit/Source/platform/FrameViewBase.cpp
[modify] https://crrev.com/45fac28e06443491e5764ef44f3136dbcd0efb54/third_party/WebKit/Source/platform/FrameViewBase.h
[modify] https://crrev.com/45fac28e06443491e5764ef44f3136dbcd0efb54/third_party/WebKit/Source/platform/HostWindow.h
[modify] https://crrev.com/45fac28e06443491e5764ef44f3136dbcd0efb54/third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp
[modify] https://crrev.com/45fac28e06443491e5764ef44f3136dbcd0efb54/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
[modify] https://crrev.com/45fac28e06443491e5764ef44f3136dbcd0efb54/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
[modify] https://crrev.com/45fac28e06443491e5764ef44f3136dbcd0efb54/third_party/WebKit/Source/platform/scroll/Scrollbar.h

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a7e111977232fbb33ad8db8bad857bbb3c68580

commit 0a7e111977232fbb33ad8db8bad857bbb3c68580
Author: joelhockey <joelhockey@chromium.org>
Date: Thu Mar 02 12:46:47 2017

Remove platform/Widget.h, it is now fully renamed to platform/FrameViewBase.h

BUG= 697351 

Review-Url: https://codereview.chromium.org/2724003002
Cr-Commit-Position: refs/heads/master@{#454239}

[modify] https://crrev.com/0a7e111977232fbb33ad8db8bad857bbb3c68580/third_party/WebKit/Source/platform/BUILD.gn
[delete] https://crrev.com/cb1950ec6514d9d4d9d5505a99300c363b30c469/third_party/WebKit/Source/platform/Widget.h

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f82c6edf451db714b211a7c92b9c1ca3547ab0ec

commit f82c6edf451db714b211a7c92b9c1ca3547ab0ec
Author: joelhockey <joelhockey@chromium.org>
Date: Mon Mar 06 01:06:02 2017

Rename ScrollableArea fields and methods *Widget* to ...FrameViewBase...

BUG= 697351 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2725273002
Cr-Commit-Position: refs/heads/master@{#454806}

[modify] https://crrev.com/f82c6edf451db714b211a7c92b9c1ca3547ab0ec/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/f82c6edf451db714b211a7c92b9c1ca3547ab0ec/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/f82c6edf451db714b211a7c92b9c1ca3547ab0ec/third_party/WebKit/Source/core/frame/RootFrameViewport.cpp
[modify] https://crrev.com/f82c6edf451db714b211a7c92b9c1ca3547ab0ec/third_party/WebKit/Source/core/frame/RootFrameViewport.h
[modify] https://crrev.com/f82c6edf451db714b211a7c92b9c1ca3547ab0ec/third_party/WebKit/Source/core/frame/VisualViewport.cpp
[modify] https://crrev.com/f82c6edf451db714b211a7c92b9c1ca3547ab0ec/third_party/WebKit/Source/core/frame/VisualViewport.h
[modify] https://crrev.com/f82c6edf451db714b211a7c92b9c1ca3547ab0ec/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/f82c6edf451db714b211a7c92b9c1ca3547ab0ec/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/f82c6edf451db714b211a7c92b9c1ca3547ab0ec/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
[modify] https://crrev.com/f82c6edf451db714b211a7c92b9c1ca3547ab0ec/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
[modify] https://crrev.com/f82c6edf451db714b211a7c92b9c1ca3547ab0ec/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1078f602af4b16ac905fbb82c3f52c7b52fc15dc

commit 1078f602af4b16ac905fbb82c3f52c7b52fc15dc
Author: joelhockey <joelhockey@chromium.org>
Date: Tue Mar 07 23:27:31 2017

Rename updateWidgetGeometry methods to updateGeometry.

BUG= 697351 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2733113002
Cr-Commit-Position: refs/heads/master@{#455285}

[modify] https://crrev.com/1078f602af4b16ac905fbb82c3f52c7b52fc15dc/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/1078f602af4b16ac905fbb82c3f52c7b52fc15dc/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/1078f602af4b16ac905fbb82c3f52c7b52fc15dc/third_party/WebKit/Source/core/layout/LayoutPart.cpp
[modify] https://crrev.com/1078f602af4b16ac905fbb82c3f52c7b52fc15dc/third_party/WebKit/Source/core/layout/LayoutPart.h
[modify] https://crrev.com/1078f602af4b16ac905fbb82c3f52c7b52fc15dc/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/1078f602af4b16ac905fbb82c3f52c7b52fc15dc/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/1078f602af4b16ac905fbb82c3f52c7b52fc15dc/third_party/WebKit/Source/platform/FrameViewBase.h
[modify] https://crrev.com/1078f602af4b16ac905fbb82c3f52c7b52fc15dc/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/1078f602af4b16ac905fbb82c3f52c7b52fc15dc/third_party/WebKit/Source/web/WebPluginContainerImpl.h

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b

commit 05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b
Author: joelhockey <joelhockey@chromium.org>
Date: Wed Mar 08 02:12:57 2017

Rename updateWidgets to updatePlugins

Methods associated with timer to update HTMLPlugInElement
(HTMLEmbedElement and HTMLObjectElement) have been renamed
from *updateWidget* to *updatePlugin*.

BUG= 697351 

Review-Url: https://codereview.chromium.org/2737713002
Cr-Commit-Position: refs/heads/master@{#455345}

[modify] https://crrev.com/05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
[modify] https://crrev.com/05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b/third_party/WebKit/Source/core/html/HTMLEmbedElement.h
[modify] https://crrev.com/05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b/third_party/WebKit/Source/core/html/HTMLEmbedElementTest.cpp
[modify] https://crrev.com/05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b/third_party/WebKit/Source/core/html/HTMLObjectElement.h
[modify] https://crrev.com/05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/05de2f6bfbe4b0628f2a2bfbea7b8ec5214a2b3b/third_party/WebKit/Source/core/html/HTMLPlugInElement.h

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf

commit 0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf
Author: joelhockey <joelhockey@chromium.org>
Date: Wed Mar 08 08:07:13 2017

Rename LayoutPart::widget to LayoutPart::frameViewBase

BUG= 697351 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2737883002
Cr-Commit-Position: refs/heads/master@{#455397}

[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/html/PluginDocument.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/layout/LayoutPart.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/layout/LayoutPart.h
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/paint/PartPainter.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/web/WebNode.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/0e1f7f7cc98ccc64094ebcbb0614264c1f2d14cf/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/062a43cf645faf5a158afa6657bb85b6a5ebd6a8

commit 062a43cf645faf5a158afa6657bb85b6a5ebd6a8
Author: joelhockey <joelhockey@chromium.org>
Date: Fri Mar 10 01:31:02 2017

Rename *isOverWidget* methods to ...isOverFrameViewBase...

BUG= 697351 

Review-Url: https://codereview.chromium.org/2735293002
Cr-Commit-Position: refs/heads/master@{#455950}

[modify] https://crrev.com/062a43cf645faf5a158afa6657bb85b6a5ebd6a8/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/062a43cf645faf5a158afa6657bb85b6a5ebd6a8/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/062a43cf645faf5a158afa6657bb85b6a5ebd6a8/third_party/WebKit/Source/core/input/ScrollManager.h
[modify] https://crrev.com/062a43cf645faf5a158afa6657bb85b6a5ebd6a8/third_party/WebKit/Source/core/layout/HitTestCache.cpp
[modify] https://crrev.com/062a43cf645faf5a158afa6657bb85b6a5ebd6a8/third_party/WebKit/Source/core/layout/HitTestResult.cpp
[modify] https://crrev.com/062a43cf645faf5a158afa6657bb85b6a5ebd6a8/third_party/WebKit/Source/core/layout/HitTestResult.h
[modify] https://crrev.com/062a43cf645faf5a158afa6657bb85b6a5ebd6a8/third_party/WebKit/Source/core/layout/LayoutPart.cpp
[modify] https://crrev.com/062a43cf645faf5a158afa6657bb85b6a5ebd6a8/third_party/WebKit/Source/core/layout/LayoutPart.h
[modify] https://crrev.com/062a43cf645faf5a158afa6657bb85b6a5ebd6a8/third_party/WebKit/Source/core/page/EventWithHitTestResults.h

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0604382f6f7580f4421387f35ef2fe559ab107b

commit e0604382f6f7580f4421387f35ef2fe559ab107b
Author: joelhockey <joelhockey@chromium.org>
Date: Wed Mar 15 02:09:30 2017

Rename Document::widgetForElement to frameViewBaseForElement

BUG= 697351 

Review-Url: https://codereview.chromium.org/2739573005
Cr-Commit-Position: refs/heads/master@{#456949}

[modify] https://crrev.com/e0604382f6f7580f4421387f35ef2fe559ab107b/third_party/WebKit/Source/core/dom/Document.cpp

Status: Fixed (was: Started)
Rename completed, further work being done under  http://crbug.com/637460 

Sign in to add a comment