New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 697343 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
█ kochi@chromium.org
dbeam@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary focus ring is seen on 'People' section of chrome://md-settings .

Reported by rk...@etouch.net, Mar 1 2017 
Chrome Version: 58.0.3027.0 0431b6bc6c9bf5624cccf1121285392b07b74ec6-refs/heads/master@{#453800}
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://md-settings
(2) Click on Main menu, select Search engine option(it will navigate to chrome://md-settings/search)
(3) Again click on 'Main menu' and observe focus ring.

Actual: Unnecessary focus ring is seen on 'People' section.

Expected: No such a focus ring should seen on 'People' section.

This is regression issue, broken in ‘M 58’ and will soon update other info :
Good build:58.0.3026.0 
Bad build: 58.0.3027.0
Actual_Focus.mp4
286 KB View Download

Comment 1 by nyerramilli@chromium.org, Mar 1 2017

Labels: ReleaseBlock-Stable OS-Linux OS-Mac OS-Windows
Owner: kochi@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,

Good build:58.0.3026.0 (453454)
Bad build: 58.0.3027.0 (453800)

You are probably looking for a change made after 453540 (known good), but no later than 453541 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/2d0c679aff7cac0b26ca5c3652745db3393a817b..1eaf120fcf6eff6426a8522de27eb3b204b1b5f9
kochi@, could you please check the issue and help.
adding RB label as this is recent regression, please change if required.

Comment 2 by nyerramilli@chromium.org, Mar 1 2017

Labels: -ReleaseBlock-Stable

Comment 3 by kochi@chromium.org, Mar 1 2017

Cc: dbeam@chromium.org
dbeam@, It looks the drawer on the left side is using <dialog> as a
container - could you confirm if this is an expected behavior or not?

Comment 4 by kochi@chromium.org, Mar 1 2017 

dbeam@ if this is something we do not want, please feel free to revert
https://codereview.chromium.org/2715793003
in time for branch cut.

Comment 5 by dbeam@chromium.org, Mar 1 2017

Cc: kochi@chromium.org
Owner: hcarmona@chromium.org
Hector: <dialog> is now able to focus inside of shadow DOM.  how does this affect the side nav?  is it still doing what we want?

Comment 6 by hcarmona@chromium.org, Mar 6 2017 

I would not expect to have the focus ring around the "people" button. If we need to focus *something* we should focus the heading to be consistent with how we show other dialogs. See  http://crbug.com/686313  for context on header focus.

Comment 7 by hcarmona@chromium.org, Mar 6 2017

Status: Started (was: Assigned)

Comment 8 by hcarmona@chromium.org, Mar 6 2017 

Same issue can be seen in history side nav
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efccf6c05043bf2ac89f090f5017e5b1bb82dd8d

commit efccf6c05043bf2ac89f090f5017e5b1bb82dd8d
Author: hcarmona <hcarmona@chromium.org>
Date: Mon Mar 06 21:41:13 2017

MD Settings: Make heading focusable in side nav.

R=dbeam@chromium.org
BUG= 697343 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2732863003
Cr-Commit-Position: refs/heads/master@{#454968}

[modify] https://crrev.com/efccf6c05043bf2ac89f090f5017e5b1bb82dd8d/chrome/browser/resources/settings/settings_ui/settings_ui.html

Comment 10 by hcarmona@chromium.org, Mar 22 2017

Status: Fixed (was: Started)
►

Sign in to add a comment