New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 697342 link

Starred by 1 user
Status: Fixed
Owner:
peter@chromium.org
Closed: Jun 2017
Cc:
█ joh...@chromium.org
mvanouwe...@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Layout Test push_messaging/permission-state-granted-in-document.html is flaky

Project Member Reported by yutak@chromium.org, Mar 1 2017 
The following layout test is flaky on all platforms

http/tests/push_messaging/permission-state-granted-in-document.html
virtual/mojo-loading/http/tests/push_messaging/permission-state-granted-in-document.html

Dashboard link:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=permission-state-granted-in-document.html

Probable cause:

Unknown.

Failure log:

This is a testharness.js-based test.
FAIL Push API: permissionState resolves with granted when permission is granted assert_unreached: unexpected rejection: assert_equals: expected "granted" but got "denied" Reached unreachable code
Harness: the test ran to completion.

Comment 1 by yutak@chromium.org, Mar 1 2017 

Updating test expectations.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01243a569e6b7be8ce4a13972fee9db3737d92bc

commit 01243a569e6b7be8ce4a13972fee9db3737d92bc
Author: yutak <yutak@chromium.org>
Date: Wed Mar 01 06:48:54 2017

permission-state-granted-in-document.html is flaky.

BUG= 697342 
TBR=fsamuel@chromium.org,sergeyu@chromium.org,dvadym@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2729513002
Cr-Commit-Position: refs/heads/master@{#453869}

[modify] https://crrev.com/01243a569e6b7be8ce4a13972fee9db3737d92bc/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by yutak@chromium.org, Mar 1 2017

Cc: joh...@chromium.org peter@chromium.org mvanouwe...@chromium.org
Status: Available (was: Untriaged)
Push messaging folks, can anyone take this bug?

Comment 4 by guidou@chromium.org, Mar 10 2017

Labels: -Sheriff-Chromium

Comment 5 by peter@chromium.org, Jun 30 2017

Cc: -peter@chromium.org
Owner: peter@chromium.org
Status: Started (was: Available)
I've got a CL out for review.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2706b3b69e4f9ccf7d8a1a7ff448970a224916e0

commit 2706b3b69e4f9ccf7d8a1a7ff448970a224916e0
Author: Peter Beverloo <peter@chromium.org>
Date: Fri Jun 30 19:56:41 2017

Update and unflake a series of push messaging permission tests

BUG= 697342 

Change-Id: Ib3b5c764ebf3086c681a8c04632bf9741768e256
Reviewed-on: https://chromium-review.googlesource.com/558354
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483796}
[modify] https://crrev.com/2706b3b69e4f9ccf7d8a1a7ff448970a224916e0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2706b3b69e4f9ccf7d8a1a7ff448970a224916e0/third_party/WebKit/LayoutTests/http/tests/push_messaging/permission-state-denied-in-document.html
[modify] https://crrev.com/2706b3b69e4f9ccf7d8a1a7ff448970a224916e0/third_party/WebKit/LayoutTests/http/tests/push_messaging/permission-state-denied-in-service-worker.html
[modify] https://crrev.com/2706b3b69e4f9ccf7d8a1a7ff448970a224916e0/third_party/WebKit/LayoutTests/http/tests/push_messaging/permission-state-exception-in-document.html
[modify] https://crrev.com/2706b3b69e4f9ccf7d8a1a7ff448970a224916e0/third_party/WebKit/LayoutTests/http/tests/push_messaging/permission-state-exception-in-service-worker.html
[modify] https://crrev.com/2706b3b69e4f9ccf7d8a1a7ff448970a224916e0/third_party/WebKit/LayoutTests/http/tests/push_messaging/permission-state-granted-in-document.html
[modify] https://crrev.com/2706b3b69e4f9ccf7d8a1a7ff448970a224916e0/third_party/WebKit/LayoutTests/http/tests/push_messaging/permission-state-granted-in-service-worker.html
[modify] https://crrev.com/2706b3b69e4f9ccf7d8a1a7ff448970a224916e0/third_party/WebKit/LayoutTests/http/tests/push_messaging/permission-state-prompt-in-document.html
[modify] https://crrev.com/2706b3b69e4f9ccf7d8a1a7ff448970a224916e0/third_party/WebKit/LayoutTests/http/tests/push_messaging/permission-state-prompt-in-service-worker.html

Comment 7 by peter@chromium.org, Jun 30 2017

Status: Fixed (was: Started)
►

Sign in to add a comment