New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697341 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Misalignment of cursor and ghost text is seen for text field of chrome://md-settings/editDictionary

Reported by jshan...@etouch.net, Mar 1 2017

Issue description

Chrome Version: 58.0.3027.0 (Official Build) 0431b6bc6c9bf5624cccf1121285392b07b74ec6-refs/heads/master@{#453800}-32/64bit
OS: Windows (7,8,8.1,10)

Steps:
1. Launch Chrome and navigate to chrome://md-settings/editDictionary
2. Click on text field and observe

Actual: Misalignment of cursor and ghost text is seen for text field of chrome://md-settings/editDictionary

Expected: Misalignment of cursor and ghost text should not be seen for text field of chrome://md-settings/editDictionary

This is regression issue, broken in ‘M 58’ and will soon update other info :

Good build:58.0.3026.0 
Bad build: 58.0.3027.0 

Note: Above issue is not seen for Mac and Linux OS

 
Actual_Expected_result.jpg
121 KB View Download
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.3026.0 (Revision: 453454).
Bad build: 58.0.3027.0 (Revision: 453800).

You are probably looking for a change made after 453683 (known good), but no later than 453684 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/5165a30947f7e933c1cc3b5d902b7bbae1873976..aa40908dd04900048559b86f7eeae484e6623e11

From the CL above, assigning the issue to the concern owner

@scottchen : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2715863002
Note :Windows specific issue and Able to reproduce in latest Canary #58.0.3027.0
Cc: kavvaru@chromium.org durga.behera@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 697371  has been merged into this issue.
Labels: OS-Linux OS-Mac
Note: Above issue is also seen for Show Home button text field and on Mac, Linux and Windows OS.
Status: Started (was: Assigned)
Labels: -Pri-1 Pri-2
This doesn't seem like a P1.

Not P1, but the Show Home button "Other" field is worse (no spacing between text and underline), because it makes it harder to read the placeholder text.

See attached (especially home-active.png).
home-active.png
21.9 KB View Download
home-placeholder.png
22.0 KB View Download
home-typing.png
21.2 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ed5d998cc82797b116a949f75da144ec3465a6d

commit 3ed5d998cc82797b116a949f75da144ec3465a6d
Author: scottchen <scottchen@chromium.org>
Date: Mon Mar 06 20:27:59 2017

MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative (https://codereview.chromium.org/2715863002), I actually shrunk the size by a couple pixels comparing to the original design. This new CL aims to fix the unintended change, and also bring one other hard-coded label in line.

BUG= 697726 , 697341 , 697778 , 697340 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2726113003
Cr-Commit-Position: refs/heads/master@{#454940}

[modify] https://crrev.com/3ed5d998cc82797b116a949f75da144ec3465a6d/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/3ed5d998cc82797b116a949f75da144ec3465a6d/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html
[modify] https://crrev.com/3ed5d998cc82797b116a949f75da144ec3465a6d/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/3ed5d998cc82797b116a949f75da144ec3465a6d/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/3ed5d998cc82797b116a949f75da144ec3465a6d/chrome/browser/resources/settings/settings_vars_css.html

Status: Fixed (was: Started)

Sign in to add a comment