Regression: 'Add search engine' overlay font appears small in size in chrome://md-settings.
Reported by
lpa...@etouch.net,
Mar 1 2017
|
|||||
Issue descriptionChrome Version: 58.0.3027.0 (Official Build) 0431b6bc6c9bf5624cccf1121285392b07b74ec6-refs/heads/master@{#453800}(32/64 Bit) OS: Windows(7,8,8.1,10) Steps to reproduce: 1. Launch Chrome, go to chrome://md-settings/searchEngines. 2. Click on ADD button for other search engines and observe the overlay. Actual Result: 'Add search engine' overlay font appears small in size. Expected Result: 'Add search engine' overlay font should appear in regular size. This is regression issue broken in 'M 58' and will soon update the bisect info: Manual Bisect Info: Good Build: 58.0.3027.0 Bad Build: 58.0.3026.0 Note: Will soon update Linux and Mac OS status once build 58.0.3027.0 is available.
,
Mar 1 2017
Using the per-revision bisect providing the bisect results, Good build: 58.0.3026.0 (Revision: 453454). Bad build: 58.0.3027.0 (Revision: 453800). You are probably looking for a change made after 453683 (known good), but no later than 453684 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/5165a30947f7e933c1cc3b5d902b7bbae1873976..aa40908dd04900048559b86f7eeae484e6623e11 From the CL above, assigning the issue to the concern owner @scottchen : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2715863002 Note :Able to reproduce the issue in Ubuntu 14.04,Win 10.0 and Mac 10.12.3 and Able to reproduce in latest Canary #58.0.3027.0
,
Mar 1 2017
Issue also reproducible on Mac(10.11.6, 10.12.1, 10.12) and Linux(14.04 LTS) OS in build #58.0.3027.0.
,
Mar 3 2017
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ed5d998cc82797b116a949f75da144ec3465a6d commit 3ed5d998cc82797b116a949f75da144ec3465a6d Author: scottchen <scottchen@chromium.org> Date: Mon Mar 06 20:27:59 2017 MD Settings: re-fix relative paper-input-label font-size. In a previous attempt to make paper-input-label font-size relative (https://codereview.chromium.org/2715863002), I actually shrunk the size by a couple pixels comparing to the original design. This new CL aims to fix the unintended change, and also bring one other hard-coded label in line. BUG= 697726 , 697341 , 697778 , 697340 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2726113003 Cr-Commit-Position: refs/heads/master@{#454940} [modify] https://crrev.com/3ed5d998cc82797b116a949f75da144ec3465a6d/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/3ed5d998cc82797b116a949f75da144ec3465a6d/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html [modify] https://crrev.com/3ed5d998cc82797b116a949f75da144ec3465a6d/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html [modify] https://crrev.com/3ed5d998cc82797b116a949f75da144ec3465a6d/chrome/browser/resources/settings/settings_page/settings_subpage_search.html [modify] https://crrev.com/3ed5d998cc82797b116a949f75da144ec3465a6d/chrome/browser/resources/settings/settings_vars_css.html
,
Mar 6 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by lpa...@etouch.net
, Mar 1 2017