New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 697338 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
█ kochi@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Focus is seen on close icon instead of text field in chrome://md-settings/searchEngines

Reported by mni...@etouch.net, Mar 1 2017 
Version: 58.0.3027.0 0431b6bc6c9bf5624cccf1121285392b07b74ec6-refs/heads/master@{#453800}
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/searchEngines and click on 'Add' button,observe grey focus highlight on overlay

Actual: Focus is seen on close icon instead of 'search engine' text field
Expected: Focus should be on 'search engine' text field

This is regression issue, broken in ‘M 58’ and will soon update other info :
Good build:58.0.3026.0 
Bad build: 58.0.3027.0
Actual_video.mp4
159 KB View Download
Expected_video.mp4
146 KB View Download

Comment 1 by rbasuvula@chromium.org, Mar 1 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: kochi@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.3026.0 (Revision: 453454).
Bad build: 58.0.3027.0 (Revision: 453800).

You are probably looking for a change made after 453540 (known good), but no later than 453541 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/2d0c679aff7cac0b26ca5c3652745db3393a817b..1eaf120fcf6eff6426a8522de27eb3b204b1b5f9

From the CL above, assigning the issue to the concern owner

@kochi : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2715793003
Note :Able to reproduce the issue in Ubuntu 14.04,Win 10.0 and Mac 10.12.3 and Able to reproduce in latest Canary #58.0.3027.0

Comment 2 by kochi@chromium.org, Mar 1 2017

Cc: dbeam@chromium.org
This is happening for the same reason as  issue 697343 .

Comment 3 by dbeam@chromium.org, Mar 1 2017

Cc: -dbeam@chromium.org kochi@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b219d44719985ddfd613cfdb95e7aca9cf005e9c

commit b219d44719985ddfd613cfdb95e7aca9cf005e9c
Author: dbeam <dbeam@chromium.org>
Date: Wed Mar 01 22:15:27 2017

MD WebUI: change how initial focus works in <dialog>s now that they know about shadow DOM

R=dpapad@chromium.org
BUG= 697338 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2727663006
Cr-Commit-Position: refs/heads/master@{#454064}

[modify] https://crrev.com/b219d44719985ddfd613cfdb95e7aca9cf005e9c/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/b219d44719985ddfd613cfdb95e7aca9cf005e9c/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/b219d44719985ddfd613cfdb95e7aca9cf005e9c/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

Comment 5 by dbeam@chromium.org, Mar 1 2017

Status: Fixed (was: Started)

Comment 6 by jmukthavaram@chromium.org, Mar 7 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3029.6
Tested the issue on windows 7, Mac 10.12.3, Linux Ubuntu 14.04 using chrome version#58.0.3029.6 with the steps mentioned in comment #0.Observed that the focus displayed on 'search engine' text field . Hence adding TE-Verified labels.
Please find the attached screen cast for the same.
Thanks!!
697338.mp4
409 KB View Download
►

Sign in to add a comment