New issue
Advanced search Search tips

Issue 697332 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Monitor uncaught JS exceptions with ts_mon

Project Member Reported by dsansome@chromium.org, Mar 1 2017

Issue description

Goal: be able to detect problems like  issue 697306 .

Ideally re-use Sean's Sheriff-o-matic code that exports the /chrome/infra/frontend/js_errors metric.
 

Comment 1 by d...@chromium.org, Mar 1 2017

Owner: ----
Status: Available (was: Assigned)

Comment 2 by d...@chromium.org, Mar 1 2017

Can you provide any more information here? These errors occur in the client, which means that they would have to be either monitored directly (seems difficult b/c creds) or exported back to the service (seems spoofable).
ths JS:
https://cs.chromium.org/chromium/infra/go/src/infra/appengine/sheriff-o-matic/scripts/clientmon.js

The handler: https://cs.chromium.org/chromium/infra/go/src/infra/appengine/sheriff-o-matic/som/main.go?l=254

It uses xsrf tokens to prevent spoofing. Of course if you have bugs in the xsrf part it won't report anything.

Once you get it set up though it'll even show you JS stack trace summaries in pantheon: https://screenshot.googleplex.com/9Cf65YLyuVq

I'd be happy to move this code out into a shared location too btw.

Comment 5 by d...@chromium.org, Mar 1 2017

Cool, thanks! I'll look into that sometime.

By "spoofing" I meant people sending you fake errors, like:
"lol sup dawg" x 100

I think this is actually still possible, since a user could just load the page 100 times (to get XSRF tokens) and send whatever data they want to the endpoint.
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 6 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by estaab@chromium.org, Apr 24 2018

Status: Archived (was: Untriaged)
Sounds cool but until this is done more generically across our web apps I don't think it will be easy to do in logdog.

Sign in to add a comment