CIPD bootstrap is broken on windows. |
||
Issue descriptiondepot_tools has a "cipd.bat", but infra's bootstrap/install_cipd_packages.py tries to invoke "cipd"+EXE_SFX, which is ".exe". If install_cipd_packages.py has never been run before there's no cipd.exe on the path, so this fails. https://screenshot.googleplex.com/D3D2BtWanci
,
Mar 1 2017
This is immediately after a "fetch infra". gclient sync fails when running install_cipd_packages.py.
,
Mar 1 2017
oh, I thought you were running the build repo's bootstrap. Just a sec.
,
Mar 1 2017
Yeah this is busted :( Talking on chat, removing '+EXE_SFX' doesn't work either (because subprocess doesn't know how to go hunt %PATH% x %PATHEXT% to find the client). There are two possibilities: * use 'shell=True' in the subprocess invocation (blech) * hunt for either cipd.exe or cipd.bat in the code Unfortunately, I suspect this bug ALSO affects recipes: https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/recipe_modules/cipd/api.py#22 But since no one ran recipes on windows with depot_tools in PATH since last week when this bug was introduced, no one found it yet.
,
Mar 1 2017
CL for recipes: https://chromiumcodereview.appspot.com/2727553005/
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a27ad879e3ff90502e01229f0107c9cd9e71b130 commit a27ad879e3ff90502e01229f0107c9cd9e71b130 Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 01 20:22:26 2017 [cipd] find cipd binary better. BUG= 697327 Change-Id: I9bc31132a820c69e21f546b67ebf2e58cfce6db9 Reviewed-on: https://chromium-review.googlesource.com/448104 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/a27ad879e3ff90502e01229f0107c9cd9e71b130/bootstrap/install_cipd_packages.py
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/18bce221976611340f2b51f200663a50f534b9fb commit 18bce221976611340f2b51f200663a50f534b9fb Author: Robert Iannucci <iannucci@chromium.org> Date: Wed Mar 01 23:50:06 2017 [cipd] use "cipd" so recipe engine can find .bat on windows. BUG= 697327 Change-Id: Ie220a09f243da08a24520203b622197be27a396b Reviewed-on: https://chromium-review.googlesource.com/448658 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/18bce221976611340f2b51f200663a50f534b9fb/recipe_modules/cipd/example.expected/win64.json [modify] https://crrev.com/18bce221976611340f2b51f200663a50f534b9fb/recipe_modules/cipd/api.py
,
Mar 2 2017
This should be fully fixed now.
,
Mar 3 2017
Awesome, thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by iannu...@google.com
, Mar 1 2017