New issue
Advanced search Search tips

Issue 697308 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
robliao@chromium.org
kylixrd@chromium.org
tapted@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

DialogClientView: Consider maxing "extra_view" buttons an explicit ui::DialogButton enum value

Project Member Reported by tapted@chromium.org, Mar 1 2017 
Chrome Version       : 58.0.3018.3

Harmony proposes moving any non-button "Extra views" into the content area of the dialogs (i.e. not in the button row).

This means all extra views should just be buttons, so we can move some boilerplate into DialogClientView and simplify some of the layout logic.

Currently ui::DialogButton is

// Dialog button identifiers used to specify which buttons to show the user.
enum DialogButton {
  DIALOG_BUTTON_NONE   = 0,
  DIALOG_BUTTON_OK     = 1,
  DIALOG_BUTTON_CANCEL = 2,
};

Making an explicit DIALOG_BUTTON_{EXTRA/AUXILIARY/ACCESSORY/ALTERNATE..} will satisfy a lot of use-cases.

Things undecided:
 - Do we need DialogDelegate::AlternateAccept()  (to match Cancel()/Accept())
 - Will post-harmony ever need a use-case for a non-button extra view in the button row? (let's aim for "no")
 - Should we support arbitrary ordering/padding (e.g. `Add Bookmark` bubble goes {<cancel>, <auxillary>, <ok>} - but also AddBookmark bubble is being revised in Harmony anyway)
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 6 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by robliao@chromium.org, Sep 13

Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 3 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 4 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 5 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 6 by pkasting@chromium.org, Sep 13

Cc: robliao@chromium.org
Status: Available (was: Archived)
We should consider doing this as part of tech debt reduction.
►

Sign in to add a comment