New issue
Advanced search Search tips

Issue 697288 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Include raw sysfs power supply data in feedback reports

Project Member Reported by derat@chromium.org, Mar 1 2017

Issue description

It'd probably be useful if power_supply_info had a --verbose flag that can be passed to increase the verbose-logging level for power_supply.cc, essentially making it report the actual power supply directories that are seen in sysfs and the raw values that are read from them. We could include this in feedback reports to help us gather more debugging info, for instance.
 

Comment 1 by derat@chromium.org, Mar 11 2017

Cc: bleung@chromium.org
Status: Started (was: Assigned)
Summary: Include raw sysfs power supply data in feedback reports (was: Add --verbose flag to power_supply_info)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1292ec5c08812e33d4d77dfbd34fe9d478f9ede4

commit 1292ec5c08812e33d4d77dfbd34fe9d478f9ede4
Author: Daniel Erat <derat@chromium.org>
Date: Mon Mar 13 05:36:34 2017

power_manager: Install print_sysfs_power_supply_data.

BUG= chromium:697288 
TEST=installed it
CQ-DEPEND=I190a727043cb3567f981df443e500d97e38f46dd

Change-Id: Ie98000602135ec9474b23e6b2fbf83f9fe43a041
Reviewed-on: https://chromium-review.googlesource.com/453219
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1292ec5c08812e33d4d77dfbd34fe9d478f9ede4/chromeos-base/power_manager/power_manager-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/45ea736c7b31b2080255d7991b5cf188eecbd8b9

commit 45ea736c7b31b2080255d7991b5cf188eecbd8b9
Author: Daniel Erat <derat@chromium.org>
Date: Mon Mar 13 05:36:35 2017

power: Add print_sysfs_power_supply_data.

Add a trivial script that prints data from
/sys/class/power_supply. I plan to include this output in
feedback reports, as the information from power_supply_info
has already been processed by powerd.

BUG= chromium:697288 
TEST=ran it; liked the output
CQ-DEPEND=Ie98000602135ec9474b23e6b2fbf83f9fe43a041

Change-Id: I190a727043cb3567f981df443e500d97e38f46dd
Reviewed-on: https://chromium-review.googlesource.com/453279
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/45ea736c7b31b2080255d7991b5cf188eecbd8b9/power_manager/tools/print_sysfs_power_supply_data

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d8b8499d288df995da1792c1b1aac71498ad91a4

commit d8b8499d288df995da1792c1b1aac71498ad91a4
Author: Daniel Erat <derat@chromium.org>
Date: Tue Mar 14 05:40:03 2017

debugd: Run print_sysfs_power_supply_data.

Make debugd run print_sysfs_power_supply_data so that raw
sysfs power supply data will be included in feedback reports
and chrome://system (as "power_supply_sysfs").

BUG= chromium:697288 
TEST=info is included at chrome://system

Change-Id: Ia4a5b2f7c2ea8b51d84858b217dd269417cb1356
Reviewed-on: https://chromium-review.googlesource.com/454122
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d8b8499d288df995da1792c1b1aac71498ad91a4/debugd/src/log_tool.cc

Comment 5 by derat@chromium.org, Mar 14 2017

Status: Fixed (was: Started)

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)
Verified in Chrome OS 9656.0.0, 61.0.3132.0.

Sign in to add a comment