New issue
Advanced search Search tips

Issue 697286 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

!document().isActive() || !document().needsLayoutTreeUpdateForNode(*this) in Ele

Project Member Reported by ClusterFuzz, Mar 1 2017

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4702562772320256

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !document().isActive() || !document().needsLayoutTreeUpdateForNode(*this) in Ele
  blink::Element::isFocusable
  blink::RadioInputType::findNextFocusableRadioButtonInGroup
  
Sanitizer: address (ASAN)

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_content_shell_drt&range=373758:373795

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97Jjm8C2QJ3AWKPrcPx8S5kacFlYT09PN4gwceA7vOGgmPzjdcx5CfC4us8dBQ6Y_kbluryBS4Pi2UMbgFx993BLbJMchgYuiAl-GG1iZYZVPslpi8y2r3pJVLTCVmxlhYJ_K4uzQdLMPupGVDpknBMPbK9uSOSf__xFthXMKwQNCnSXp0rPlioNGhnaNeJksNZdwZaVuSlrGWYceLH0wGJJLlROXCZB-zik0hQq6SHnW9d80m5qAdoj7StbDMrP4aPPMVQxe8aLap-gZ5w7s3Qe_ay11tGnIalbU5S2rzOHpy0OtZKDLVYGbjJtICywioxuwrS05tqDHocl6jSsPqtqDi3BGJgW0mVAmdZ-_A-fE-xUf1QJASS9k1m0gke5nfvJJNZ1LTTF9pwXhhDTVKcVVIYxQ?testcase_id=4702562772320256


Additional requirements: Requires Gestures

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Blink>Focus
Labels: Test-Predator-Wrong M-58
Owner: nainar@chromium.org
Status: Assigned (was: Untriaged)
Through code search on file Element.cpp, suspected CL is 
https://chromium.googlesource.com/chromium/src/+/8b6c7b7ce5a36d8eda49dd6e60c5e7c8f5c7277f
nainar@, could you please take a look?.
Thank you

Comment 2 by kochi@chromium.org, Mar 1 2017

Naina, I recently fixed an issue with the similar crash pattern ( issue 677690 ).
But at a glance of the crash (which is happening in <input type="radio">)
backtrace, probably a separate issue.

If you think the CL above is innocent, feel free to assign to me.
Owner: tkent@chromium.org
https://codereview.chromium.org/1667623002 This CL seems like a better suspect than my CL which is not in the regression range. Assigning to tkent@

Comment 4 by tkent@chromium.org, Mar 15 2017

Components: Blink>Forms>Radio
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f2e671f3872dafcc110ac0fb5e6615e6898f88f

commit 2f2e671f3872dafcc110ac0fb5e6615e6898f88f
Author: tkent <tkent@chromium.org>
Date: Wed Mar 15 06:11:54 2017

INPUT element: Fix a DCHECK failure in RadioInputType::findNextFocusableRadioButtonInGroup.

The function calls isFocusable(), and we need to make sure that the layout is up
to date.

BUG= 697286 

Review-Url: https://codereview.chromium.org/2745103008
Cr-Commit-Position: refs/heads/master@{#457007}

[modify] https://crrev.com/2f2e671f3872dafcc110ac0fb5e6615e6898f88f/third_party/WebKit/Source/core/html/HTMLInputElement.h
[modify] https://crrev.com/2f2e671f3872dafcc110ac0fb5e6615e6898f88f/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
[modify] https://crrev.com/2f2e671f3872dafcc110ac0fb5e6615e6898f88f/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp

Comment 6 by tkent@chromium.org, Mar 15 2017

Labels: -M-58
Status: Fixed (was: Started)
Project Member

Comment 7 by ClusterFuzz, Mar 18 2017

ClusterFuzz has detected this issue as fixed in range 456626:457730.

Detailed report: https://clusterfuzz.com/testcase?key=4702562772320256

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !document().isActive() || !document().needsLayoutTreeUpdateForNode(*this) in Ele
  blink::Element::isFocusable
  blink::RadioInputType::findNextFocusableRadioButtonInGroup
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_content_shell_drt&range=373758:373795
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_content_shell_drt&range=456626:457730

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv94q1uJYFmnMw7tzWjLZl4qtsbacy1uun40022Z74OPWI2lOqRzXffmfGUuWujqI0bmrW76SAfRbbOxTxyQXsdoCNVyFDyCQfma2Oo81T_6Hoq0kACH_d2fvpLURuhOw9I8GrOXOt_x-_evIi3KwaKc4Z9BsFl5DPJijBGhg_6qANL8z63qamAASdMtJXT3YLqiaYohDBXuH60zug4hMoQnxbe-3HuRe22fNTEVxQJ3XgocKjN5yTgbo-nbUAjp6-cf2II-U85YF15E55ZsrH26PKBmQmtQege12sDRLtB3bO739fHjn31demkZ0tROyhp6rkcdDhUDeGdGHSHCuH1Nc19VNE0sAEy3EvRqCQjCDRgmI3UFBMrsQZ6YRzSEec6gxUl2XuVQz90azePrnAtLq-MplJA?testcase_id=4702562772320256


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Components: Blink>HTML>Focus
Components: -Blink>Focus

Sign in to add a comment