New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697273 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Fix flicker in network panel if large stream of requests come in.

Project Member Reported by allada@chromium.org, Mar 1 2017

Issue description

Right now if network panel receives many requests come in quickly it flickers.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2be7423611e6bfdb7400e46c6d265f53c3888a3

commit c2be7423611e6bfdb7400e46c6d265f53c3888a3
Author: allada <allada@chromium.org>
Date: Thu Mar 02 18:48:12 2017

[Devtools] Fixed flicker in network for large stream of requests

This patch updates network to update the ViewportDataGrid instantly
which fixes the flicker.

Reason this occurs is because network gets an update to a request which
schedules an update. It finds a new node now needs to be added so it
sends it to datagrid and waterfall to be added which Waterfall processes
immidatly, but ViewportDataGrid schedules the next frame to insert the
new nodes. The scroller then gets synced and stick to bottom kicks in
which causes the scroller to scroll down which reveals blank area in the
ViewportDataGrid.

R=pfeldman
BUG= 697273 

Review-Url: https://codereview.chromium.org/2726763002
Cr-Commit-Position: refs/heads/master@{#454319}

[modify] https://crrev.com/c2be7423611e6bfdb7400e46c6d265f53c3888a3/third_party/WebKit/LayoutTests/inspector/components/viewport-datagrid.html
[modify] https://crrev.com/c2be7423611e6bfdb7400e46c6d265f53c3888a3/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
[modify] https://crrev.com/c2be7423611e6bfdb7400e46c6d265f53c3888a3/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Labels: Merge-Request-57
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 2 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls update appropriate OS labels. Thank you.
Labels: -Hotlist-Merge-Review -Merge-Review-57

Comment 6 by allada@chromium.org, Jul 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment