New issue
Advanced search Search tips

Issue 697246 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 690204


Show other hotlists

Hotlists containing this issue:
web-bluetooth


Sign in to add a comment

bluetooth: mac: Be resistant if the device is modified while discovering services

Project Member Reported by jlebel@chromium.org, Feb 28 2017

Issue description

If a device sends a modify notification, right after asking for services but before receiving the result. We should start a new service discovery request, and make sure we receive both answer before starting to discover for characteristics.
 
Blocking: 690204
Summary: bluetooth: mac: Be resistant if the device is modified while discovering services (was: bluetooth: macOS: Be resistant if the device is modified while discovering services)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d7b7b5667f623683dcc42b6c60da2274ab1eb26

commit 0d7b7b5667f623683dcc42b6c60da2274ab1eb26
Author: jlebel <jlebel@chromium.org>
Date: Mon Mar 06 23:57:33 2017

Bluetooth: macOS: Adding counter for service discovery callbacks.

Each time -[CBPeripheral discoverServices:] is called, BluetoothLowEnergyDeviceMac::DiscoverPrimaryServices()
has to be called for the device to complete.

BUG= 697246 

Review-Url: https://codereview.chromium.org/2641133003
Cr-Commit-Position: refs/heads/master@{#455002}

[modify] https://crrev.com/0d7b7b5667f623683dcc42b6c60da2274ab1eb26/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/0d7b7b5667f623683dcc42b6c60da2274ab1eb26/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/0d7b7b5667f623683dcc42b6c60da2274ab1eb26/device/bluetooth/bluetooth_low_energy_device_mac.h
[modify] https://crrev.com/0d7b7b5667f623683dcc42b6c60da2274ab1eb26/device/bluetooth/bluetooth_low_energy_device_mac.mm
[modify] https://crrev.com/0d7b7b5667f623683dcc42b6c60da2274ab1eb26/device/bluetooth/test/bluetooth_test_mac.h
[modify] https://crrev.com/0d7b7b5667f623683dcc42b6c60da2274ab1eb26/device/bluetooth/test/bluetooth_test_mac.mm
[modify] https://crrev.com/0d7b7b5667f623683dcc42b6c60da2274ab1eb26/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h
[modify] https://crrev.com/0d7b7b5667f623683dcc42b6c60da2274ab1eb26/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm

Status: Fixed (was: Started)

Sign in to add a comment