New issue
Advanced search Search tips

Issue 697241 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Media canPlay() tests are non-spec compliant

Project Member Reported by jrumm...@chromium.org, Feb 28 2017

Issue description

Part of the tests in media/media-can-play-webm.html and media/media-can-play-ogg.html call canPlay() with MIME types that don't properly conform to RFC6381 ("MIME Codecs and Profiles").

Examples:
    video.canPlayType("video/ogg; codecs=theora,vorbis")
    video.canPlayType("video/webm; codecs=vp8.0,opus")

Section 3.2 of RFC6381 ("MIME Codecs and Profiles"):
      cod-simple  := "codecs" "=" unencodedv
      unencodedv  := id-simple / simp-list
      simp-list   := DQUOTE id-simple *( "," id-simple ) DQUOTE
      id-simple   := element
                  ; "." reserved as hierarchy delimiter
      element     := 1*octet-sim
      octet-sim   := <any TOKEN character>
      DQUOTE      := %x22 ; " (double quote)
TOKEN comes from RFC2045, which excludes "," (and a bunch of other characters).

So the RFC states that a list of codecs (simp-list) needs to inside DQUOTEs. All the calls inside the 2 tests mentioned above that provide a list of codecs do not include the quotes.

 
Owner: jrumm...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ed1f13bda118c1ca19f8ddb649ba165ff6969d5

commit 4ed1f13bda118c1ca19f8ddb649ba165ff6969d5
Author: jrummell <jrummell@chromium.org>
Date: Thu Mar 02 19:54:35 2017

Update media canPlayType() tests to be spec-compliant

RFC6381 (MIME Codecs and Profiles) specifies that a list of codecs must be
enclosed within double quotes. Updating the canPlayType() tests to do that.

BUG= 697241 
TEST=updated tests pass

Review-Url: https://codereview.chromium.org/2723323002
Cr-Commit-Position: refs/heads/master@{#454353}

[modify] https://crrev.com/4ed1f13bda118c1ca19f8ddb649ba165ff6969d5/third_party/WebKit/LayoutTests/media/media-can-play-ogg.html
[modify] https://crrev.com/4ed1f13bda118c1ca19f8ddb649ba165ff6969d5/third_party/WebKit/LayoutTests/media/media-can-play-webm.html

Status: Fixed (was: Started)

Sign in to add a comment