New issue
Advanced search Search tips

Issue 697235 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Implementing erase/erase_if from library fundamentals ts v2.

Reported by dyaros...@yandex-team.ru, Feb 28 2017

Issue description

In library fundamentals TS v2 http://en.cppreference.com/w/cpp/experimental/lib_extensions_2
there is an easy to implement very useful functionality:
standalone erase/erase_if functions that remove elements from the container in the most appropriate for it way.

In https://codereview.chromium.org/2690303012/ pkasting suggest implementing them in stl_utlis by the name of STLErase.
 
Components: Internals>Core
Labels: -OS-Mac OS-All
Status: Available (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dd3a2137bac37d60ec0d4b43cdbcb8eb9d44879

commit 5dd3a2137bac37d60ec0d4b43cdbcb8eb9d44879
Author: jdoerrie <jdoerrie@chromium.org>
Date: Mon Mar 13 15:31:10 2017

Fix Template Parameter List for Associative Containers in base::EraseIf

This change fixes the template parameter lists of associative containers for
base::EraseIf. For example, trying to use base::EraseIf with a std::map using a
custom comparator would have resulted in a compilation error before this change.

BUG= 697235 
R=dyaroshev@yandex-team.ru, danakj@chromium.org, pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2746053002
Cr-Commit-Position: refs/heads/master@{#456385}

[modify] https://crrev.com/5dd3a2137bac37d60ec0d4b43cdbcb8eb9d44879/base/stl_util.h
[modify] https://crrev.com/5dd3a2137bac37d60ec0d4b43cdbcb8eb9d44879/base/stl_util_unittest.cc

Is this done?
@thestig

Yes.
Status: Fixed (was: Available)

Sign in to add a comment