New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 697234 link

Starred by 1 user
Status: Fixed
Owner:
█ raymes@chromium.org
OOO until 4th Feb
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

ContentSettingsType is out of sync with histograms.xml

Project Member Reported by lgar...@chromium.org, Feb 28 2017 
For example, the following two CLs added enum values out of order, and did not update histograms.xml

https://codereview.chromium.org/1382783002
https://codereview.chromium.org/1706503002

raymes@: Any chance you could figure exactly what happened (do we need to re-interpret any UMA stats?) and fix histograms.xml today?
If not, punt back to me and I'll do it.

Comment 1 by raymes@chromium.org, Feb 28 2017 

The ContentSettingsType enum isn't the one that's used to determine the histogram value. See content_settings.cc.

It does look like one setting was added that isn't in sync: background sync will correspond to bluetooth guard. Everything else should be correct. Some more recent settings weren't added to the histogram. I'll write a CL to try to make things clearer here. It probably won't happen today but I'll get to it this week. Does that work for you?
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5e0038e479176c8e130882203ca4567f169b38b

commit c5e0038e479176c8e130882203ca4567f169b38b
Author: raymes <raymes@chromium.org>
Date: Tue Apr 18 00:27:45 2017

Make it harder to get ContentSettingsType histogram values wrong

This CL forces the histogram value for a content setting to be
explicitly specified to reduce the risk of getting out of sync with
histograms.xml.

BUG= 697234 

Review-Url: https://codereview.chromium.org/2728303002
Cr-Commit-Position: refs/heads/master@{#465076}

[modify] https://crrev.com/c5e0038e479176c8e130882203ca4567f169b38b/components/content_settings/core/common/content_settings.cc
[modify] https://crrev.com/c5e0038e479176c8e130882203ca4567f169b38b/tools/metrics/histograms/histograms.xml

Comment 3 by raymes@chromium.org, Apr 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment